Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Side by Side Diff: runtime/vm/flow_graph_builder.h

Issue 14386011: Fix recognition of factories (for setting result cid) and add them to checks. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_FLOW_GRAPH_BUILDER_H_ 5 #ifndef VM_FLOW_GRAPH_BUILDER_H_
6 #define VM_FLOW_GRAPH_BUILDER_H_ 6 #define VM_FLOW_GRAPH_BUILDER_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/ast.h" 9 #include "vm/ast.h"
10 #include "vm/growable_array.h" 10 #include "vm/growable_array.h"
11 #include "vm/intermediate_language.h" 11 #include "vm/intermediate_language.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 class FlowGraph; 15 class FlowGraph;
16 class Instruction; 16 class Instruction;
17 class ParsedFunction; 17 class ParsedFunction;
18 18
19 // List of recognized list factories:
20 // (factory-name-symbol, result-cid, fingerprint).
21 // TODO(srdjan): Store the values in the snapshot instead.
22 #define RECOGNIZED_LIST_FACTORY_LIST(V) \
23 V(ObjectArrayFactory, kArrayCid, 97987288) \
24 V(GrowableObjectArrayWithData, kGrowableObjectArrayCid, 816132033) \
25 V(GrowableObjectArrayFactory, kGrowableObjectArrayCid, 552407276) \
26 V(_Int8ArrayFactory, kTypedDataInt8ArrayCid, 974805301) \
27 V(_Uint8ArrayFactory, kTypedDataUint8ArrayCid, 839639001) \
28 V(_Uint8ClampedArrayFactory, kTypedDataUint8ClampedArrayCid, 1947193032) \
29 V(_Int16ArrayFactory, kTypedDataInt16ArrayCid, 1492289327) \
30 V(_Uint16ArrayFactory, kTypedDataUint16ArrayCid, 358109132) \
31 V(_Int32ArrayFactory, kTypedDataInt32ArrayCid, 1238390459) \
32 V(_Uint32ArrayFactory, kTypedDataUint32ArrayCid, 1091191177) \
33 V(_Int64ArrayFactory, kTypedDataInt64ArrayCid, 569474614) \
34 V(_Uint64ArrayFactory, kTypedDataUint64ArrayCid, 1778132384) \
35 V(_Float64ArrayFactory, kTypedDataFloat64ArrayCid, 740945295) \
36 V(_Float32ArrayFactory, kTypedDataFloat32ArrayCid, 630024167) \
37 V(_Float32x4ArrayFactory, kTypedDataFloat32x4ArrayCid, 1881134784) \
38
39
19 // An class to collect the exits from an inlined function during graph 40 // An class to collect the exits from an inlined function during graph
20 // construction so they can be plugged into the caller's flow graph. 41 // construction so they can be plugged into the caller's flow graph.
21 class InlineExitCollector: public ZoneAllocated { 42 class InlineExitCollector: public ZoneAllocated {
22 public: 43 public:
23 InlineExitCollector(FlowGraph* caller_graph, Definition* call) 44 InlineExitCollector(FlowGraph* caller_graph, Definition* call)
24 : caller_graph_(caller_graph), call_(call), exits_(4) { } 45 : caller_graph_(caller_graph), call_(call), exits_(4) { }
25 46
26 void AddExit(ReturnInstr* exit); 47 void AddExit(ReturnInstr* exit);
27 48
28 // Before replacing a call with a graph, the outer environment needs to be 49 // Before replacing a call with a graph, the outer environment needs to be
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 // Output parameters. 478 // Output parameters.
458 GrowableArray<TargetEntryInstr**> true_successor_addresses_; 479 GrowableArray<TargetEntryInstr**> true_successor_addresses_;
459 GrowableArray<TargetEntryInstr**> false_successor_addresses_; 480 GrowableArray<TargetEntryInstr**> false_successor_addresses_;
460 481
461 intptr_t condition_token_pos_; 482 intptr_t condition_token_pos_;
462 }; 483 };
463 484
464 } // namespace dart 485 } // namespace dart
465 486
466 #endif // VM_FLOW_GRAPH_BUILDER_H_ 487 #endif // VM_FLOW_GRAPH_BUILDER_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698