Fix recognition of factories (for setting result cid) and add them to checks.

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/code_descriptors.h"
 #include "vm/dart_entry.h"
@@ skipping 2028 matching lines @@
   arguments->Add(push_ctor_arg);
 
   BuildPushArguments(*node->arguments(), arguments);
   Do(new StaticCallInstr(node->token_pos(),
                          node->constructor(),
                          node->arguments()->names(),
                          arguments));
 }
 
 
-// List of recognized list factories in core lib:
-// (factory-name-symbol, result-cid, fingerprint).
-// TODO(srdjan): Store the values in the snapshot instead.
-#define RECOGNIZED_LIST_FACTORY_LIST(V)                                        \
-  V(ObjectArrayFactory, kArrayCid, 97987288)                                   \
-  V(GrowableObjectArrayWithData, kGrowableObjectArrayCid, 816132033)           \
-  V(GrowableObjectArrayFactory, kGrowableObjectArrayCid, 552407276)            \
-  V(Int8ListFactory, kTypedDataInt8ArrayCid, 1299195009)                       \
-  V(Uint8ListFactory, kTypedDataUint8ArrayCid, 1493118613)                     \
-  V(Uint8ClampedListFactory, kTypedDataUint8ClampedArrayCid, 642014193)        \
-  V(Int16ListFactory, kTypedDataInt16ArrayCid, 1346619471)                     \
-  V(Uint16ListFactory, kTypedDataUint16ArrayCid, 1374024153)                   \
-  V(Int32ListFactory, kTypedDataInt32ArrayCid, 1583592980)                     \
-  V(Uint32ListFactory, kTypedDataUint32ArrayCid, 1940214615)                   \
-  V(Int64ListFactory, kTypedDataInt64ArrayCid, 108181413)                      \
-  V(Uint64ListFactory, kTypedDataUint64ArrayCid, 375587484)                    \
-  V(Float64ListFactory, kTypedDataFloat64ArrayCid, 919047725)                  \
-  V(Float32ListFactory, kTypedDataFloat32ArrayCid, 1038684997)                 \
-  V(Float32x4ListFactory, kTypedDataFloat32x4ArrayCid, 801641591)              \
-
-
 // Class that recognizes factories and returns corresponding result cid.
 class FactoryRecognizer : public AllStatic {
  public:
   // Return kDynamicCid if factory is not recognized.
   static intptr_t ResultCid(const Function& factory) {
     ASSERT(factory.IsFactory());
     const Class& function_class = Class::Handle(factory.Owner());
     const Library& lib = Library::Handle(function_class.library());
     ASSERT((lib.raw() == Library::CoreLibrary()) ||
         (lib.raw() == Library::TypedDataLibrary()));
@@ skipping 1301 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart