Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1438553003: XFA: Use c++ style casts elsewhere in xfa_ffnotify.cpp (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Use c++ style casts elsewhere in xfa_ffnotify.cpp Added FIXMEs to the spots where danger lurks. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4231e56531dc48d910b9e66dcbe6cde78df35c39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -31 lines) Patch
M xfa/src/fxfa/src/app/xfa_ffnotify.cpp View 19 chunks +48 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, please review. I wanted to be sure there weren't others lurking in this file.
5 years, 1 month ago (2015-11-10 22:41:44 UTC) #2
Lei Zhang
lgtm
5 years, 1 month ago (2015-11-11 00:46:47 UTC) #3
Tom Sepez
5 years, 1 month ago (2015-11-11 17:47:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4231e56531dc48d910b9e66dcbe6cde78df35c39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698