|
|
Index: tools/checklicenses/checklicenses.py |
diff --git a/tools/checklicenses/checklicenses.py b/tools/checklicenses/checklicenses.py |
index fe08d7068dc80e0f8e950c45602ed22add231c76..45e6bd7a8834b9a86f988767877e0615b34b0bb7 100755 |
--- a/tools/checklicenses/checklicenses.py |
+++ b/tools/checklicenses/checklicenses.py |
@@ -458,6 +458,9 @@ PATH_SPECIFIC_WHITELISTED_LICENSES = { |
'third_party/modp_b64': [ |
'UNKNOWN', |
], |
+ 'third_party/openh264/src': [ |
Paweł Hajdan Jr.
2015/11/12 15:55:03
Could you please file an upstream bug about missin
Could you please file an upstream bug about missing license headers?
Some files do have proper license headers and our tooling recognizes them.
However, that's not the case for all files here.
I'd like to stress that despite the tool confusingly says "No copyright", what
we're actually interested in for Chromium are just license headers. It's NOT
necessary to have copyright headers.
It's also fine to proceed with this CL once upstream (not chromium) bug is on
file and added as a comment to the whitelist here.
$ ./third_party/devscripts/licensecheck.pl -r third_party/openh264/ | grep
UNKNOWN
third_party/openh264/src/testbin/CmdLineExample.sh: *No copyright* UNKNOWN
third_party/openh264/src/build/mktargets.py: *No copyright* UNKNOWN
third_party/openh264/src/build/mktargets.sh: *No copyright* UNKNOWN
third_party/openh264/src/autotest/unitTest/android/run_AutoTest_android.sh: *No
copyright* UNKNOWN
third_party/openh264/src/autotest/unitTest/ios/run_AutoTest_ios.sh: *No
copyright* UNKNOWN
third_party/openh264/src/autotest/unitTest/run_unitTest.sh: *No copyright*
UNKNOWN
third_party/openh264/src/autotest/performanceTest/android/run_AutoTest_android.sh:
*No copyright* UNKNOWN
third_party/openh264/src/autotest/performanceTest/ios/run_AutoTest_ios.sh: *No
copyright* UNKNOWN
third_party/openh264/src/autotest/performanceTest/parsePerfData.sh: *No
copyright* UNKNOWN
third_party/openh264/src/code-coverage.sh: *No copyright* UNKNOWN
third_party/openh264/src/docs/doxygen2rst.py: *No copyright* UNKNOWN
third_party/openh264/src/codec/build/android/dec/jni/myjni.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/codec/build/android/dec/src/com/wels/dec/WelsDecTest.java:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/android/enc/jni/myjni.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/codec/build/android/enc/src/com/wels/enc/WelsEncTest.java:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/Properties/AssemblyInfo.cs:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/App.xaml.cs: *No
copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/MainPage.xaml.cs:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/LocalizedStrings.cs:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecRTComponent.h: *No
copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecRTComponent.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/codec/common/generate_version.sh: *No copyright*
UNKNOWN
third_party/openh264/src/codec/common/inc/version.h: *No copyright* UNKNOWN
third_party/openh264/src/codec/common/inc/deblocking_common.h: *No copyright*
UNKNOWN
third_party/openh264/src/codec/common/src/deblocking_common.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/run_Test.sh: *No copyright* UNKNOWN
third_party/openh264/src/test/processing/ProcessUT_VaaCalc.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/processing/ProcessUT_ScrollDetection.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/processing/ProcessUT_DownSample.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/processing/ProcessUT_AdaptiveQuantization.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/utils/InputStream.h: *No copyright* UNKNOWN
third_party/openh264/src/test/utils/HashFunctions.h: *No copyright* UNKNOWN
third_party/openh264/src/test/utils/FileInputStream.h: *No copyright* UNKNOWN
third_party/openh264/src/test/utils/DataGenerator.h: *No copyright* UNKNOWN
third_party/openh264/src/test/utils/BufferedData.h: *No copyright* UNKNOWN
third_party/openh264/src/test/build/android/jni/codec_unittest.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/build/android/src/com/cisco/codec/unittest/MainActivity.java:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/ViewController.m:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/ViewController.h:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/AppDelegate.m:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/main.m:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/AppDelegate.h:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/Properties/AssemblyInfo.cs:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/App.xaml.cs:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/MainPage.xaml.cs:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/LocalizedStrings.cs:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/Codec_UT_RTComponent.h:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/Codec_UT_RTComponent.cpp:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/run_PrepareAllTestData.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_ParseYUVInfo.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_SafeDelete.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_BitStreamToYUV.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_BinarySHA1Comparison.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/run_Main.sh: *No
copyright* UNKNOWN
third_party/openh264/src/test/decoder/DecUT_IdctResAddPred.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_ErrorConcealment.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_DecExt.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/decoder/DecUT_DeblockCommon.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_ParseSyntax.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_Deblock.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/decoder/DecUT_IntraPrediction.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_PredMv.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MotionCompensation.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_ExpGolomb.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_ParameterSetStrategy.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_Sample.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MotionEstimate.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MBCopy.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_DecodeMbAux.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_GetIntraPredictor.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_EncoderMb.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_EncoderMbAux.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_SVC_me.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_InterfaceTest.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MemoryAlloc.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MemoryZero.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_EncoderExt.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_Reconstruct.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/api/simple_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/decoder_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/encoder_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/BaseEncoderTest.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/encode_decode_api_test.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/api/c_interface_test.c: *No copyright* UNKNOWN
third_party/openh264/src/test/api/BaseDecoderTest.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/cpp_interface_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/DataGenerator.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/decode_encode_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/BaseEncoderTest.h: *No copyright* UNKNOWN
third_party/openh264/src/test/BaseDecoderTest.h: *No copyright* UNKNOWN
third_party/openh264/src/test/test_stdint.h: *No copyright* UNKNOWN
third_party/openh264/src/test/common/ExpandPicture.cpp: *No copyright* UNKNOWN
hbos_chromium
2015/11/13 10:43:50
Ack. Created an upstream bug and added a comment l
On 2015/11/12 15:55:03, Paweł Hajdan Jr. wrote:
> Could you please file an upstream bug about missing license headers?
>
> Some files do have proper license headers and our tooling recognizes them.
> However, that's not the case for all files here.
>
> I'd like to stress that despite the tool confusingly says "No copyright", what
> we're actually interested in for Chromium are just license headers. It's NOT
> necessary to have copyright headers.
>
> It's also fine to proceed with this CL once upstream (not chromium) bug is on
> file and added as a comment to the whitelist here.
>
> $ ./third_party/devscripts/licensecheck.pl -r third_party/openh264/ | grep
> UNKNOWN
> third_party/openh264/src/testbin/CmdLineExample.sh: *No copyright* UNKNOWN
> third_party/openh264/src/build/mktargets.py: *No copyright* UNKNOWN
> third_party/openh264/src/build/mktargets.sh: *No copyright* UNKNOWN
> third_party/openh264/src/autotest/unitTest/android/run_AutoTest_android.sh:
*No
> copyright* UNKNOWN
> third_party/openh264/src/autotest/unitTest/ios/run_AutoTest_ios.sh: *No
> copyright* UNKNOWN
> third_party/openh264/src/autotest/unitTest/run_unitTest.sh: *No copyright*
> UNKNOWN
>
third_party/openh264/src/autotest/performanceTest/android/run_AutoTest_android.sh:
> *No copyright* UNKNOWN
> third_party/openh264/src/autotest/performanceTest/ios/run_AutoTest_ios.sh: *No
> copyright* UNKNOWN
> third_party/openh264/src/autotest/performanceTest/parsePerfData.sh: *No
> copyright* UNKNOWN
> third_party/openh264/src/code-coverage.sh: *No copyright* UNKNOWN
> third_party/openh264/src/docs/doxygen2rst.py: *No copyright* UNKNOWN
> third_party/openh264/src/codec/build/android/dec/jni/myjni.cpp: *No copyright*
> UNKNOWN
>
third_party/openh264/src/codec/build/android/dec/src/com/wels/dec/WelsDecTest.java:
> *No copyright* UNKNOWN
> third_party/openh264/src/codec/build/android/enc/jni/myjni.cpp: *No copyright*
> UNKNOWN
>
third_party/openh264/src/codec/build/android/enc/src/com/wels/enc/WelsEncTest.java:
> *No copyright* UNKNOWN
>
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/Properties/AssemblyInfo.cs:
> *No copyright* UNKNOWN
> third_party/openh264/src/codec/build/windowsphone/all/CodecApp/App.xaml.cs:
*No
> copyright* UNKNOWN
>
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/MainPage.xaml.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/LocalizedStrings.cs:
> *No copyright* UNKNOWN
> third_party/openh264/src/codec/build/windowsphone/all/CodecRTComponent.h: *No
> copyright* UNKNOWN
> third_party/openh264/src/codec/build/windowsphone/all/CodecRTComponent.cpp:
*No
> copyright* UNKNOWN
> third_party/openh264/src/codec/common/generate_version.sh: *No copyright*
> UNKNOWN
> third_party/openh264/src/codec/common/inc/version.h: *No copyright* UNKNOWN
> third_party/openh264/src/codec/common/inc/deblocking_common.h: *No copyright*
> UNKNOWN
> third_party/openh264/src/codec/common/src/deblocking_common.cpp: *No
copyright*
> UNKNOWN
> third_party/openh264/src/run_Test.sh: *No copyright* UNKNOWN
> third_party/openh264/src/test/processing/ProcessUT_VaaCalc.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/processing/ProcessUT_ScrollDetection.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/processing/ProcessUT_DownSample.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/processing/ProcessUT_AdaptiveQuantization.cpp:
*No
> copyright* UNKNOWN
> third_party/openh264/src/test/utils/InputStream.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/utils/HashFunctions.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/utils/FileInputStream.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/utils/DataGenerator.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/utils/BufferedData.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/build/android/jni/codec_unittest.cpp: *No
> copyright* UNKNOWN
>
third_party/openh264/src/test/build/android/src/com/cisco/codec/unittest/MainActivity.java:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/ViewController.m:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/ViewController.h:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/AppDelegate.m:
> *No copyright* UNKNOWN
> third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/main.m:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/AppDelegate.h:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/Properties/AssemblyInfo.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/App.xaml.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/MainPage.xaml.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/LocalizedStrings.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/Codec_UT_RTComponent.h:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/Codec_UT_RTComponent.cpp:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/run_PrepareAllTestData.sh:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_ParseYUVInfo.sh:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_SafeDelete.sh:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_BitStreamToYUV.sh:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_BinarySHA1Comparison.sh:
> *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder_binary_comparison/run_Main.sh: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_IdctResAddPred.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_ErrorConcealment.cpp: *No
copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_DecExt.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_DeblockCommon.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_ParseSyntax.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_Deblock.cpp: *No copyright*
UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_IntraPrediction.cpp: *No
copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_PredMv.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MotionCompensation.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_ExpGolomb.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_ParameterSetStrategy.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_Sample.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MotionEstimate.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MBCopy.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_DecodeMbAux.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_GetIntraPredictor.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_EncoderMb.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_EncoderMbAux.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_SVC_me.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_InterfaceTest.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MemoryAlloc.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MemoryZero.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_EncoderExt.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_Reconstruct.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/api/simple_test.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/decoder_test.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/encoder_test.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/BaseEncoderTest.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/encode_decode_api_test.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/api/c_interface_test.c: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/BaseDecoderTest.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/cpp_interface_test.cpp: *No copyright*
UNKNOWN
> third_party/openh264/src/test/api/DataGenerator.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/decode_encode_test.cpp: *No copyright*
UNKNOWN
> third_party/openh264/src/test/BaseEncoderTest.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/BaseDecoderTest.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/test_stdint.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/common/ExpandPicture.cpp: *No copyright* UNKNOWN
Ack. Created an upstream bug and added a comment linking to it.
|
+ 'UNKNOWN', |
+ ], |
'third_party/openmax_dl/dl' : [ |
'Khronos Group', |
], |