Preparation work for third_party/openh264 build-from-src CL

Preparation work for third_party/openh264 build-from-src CL

This CL reverts the parts of https://codereview.chromium.org/1394983003/ that added dummy unittest binaries for openh264.
This was decided to be a bad move (overhead of binaries, only wanting the tests if flag is set). The unittests will be placed and implemented in content_unittests instead in a follow-up CL.

This CL also pulls in openh264/src source code. The building of this and test code will be added in a follow-up CL.

BUG=500605, 468365
Committed: https://crrev.com/dc28e3ffd89faa7cf1a38ca63084685186534108
Cr-Commit-Position: refs/heads/master@{#359548}

[hbos_chromium, 2015-11-10 16:23:15]

The CQ bit was checked by hbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-10 16:23:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438553002/1

[commit-bot: I haz the power, 2015-11-10 16:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 16:23:55]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[hbos_chromium, 2015-11-10 16:29:28]

Description was changed from

==========
Preparation work for third_party/openh264 build-from-src CL

This CL reverts https://codereview.chromium.org/1394983003/ which added dummy
unittest binaries for openh264.
This was decided to be a bad move (overhead of binaries, only wanting the tests
if flag is set). The unittests will be places in content_unittests instead in a
follow-up CL.

This CL also pulls in openh264/src source code. The building of this and test
code will be added in a follow-up CL.

BUG=500605
==========

to

==========
Preparation work for third_party/openh264 build-from-src CL

This CL reverts https://codereview.chromium.org/1394983003/ which added dummy
unittest binaries for openh264.
This was decided to be a bad move (overhead of binaries, only wanting the tests
if flag is set). The unittests will be places in content_unittests instead in a
follow-up CL.

This CL also pulls in openh264/src source code. The building of this and test
code will be added in a follow-up CL.

BUG=500605, 468365
==========

[hbos_chromium, 2015-11-10 16:32:11]

Description was changed from

==========
Preparation work for third_party/openh264 build-from-src CL

This CL reverts https://codereview.chromium.org/1394983003/ which added dummy
unittest binaries for openh264.
This was decided to be a bad move (overhead of binaries, only wanting the tests
if flag is set). The unittests will be places in content_unittests instead in a
follow-up CL.

This CL also pulls in openh264/src source code. The building of this and test
code will be added in a follow-up CL.

BUG=500605, 468365
==========

to

==========
Preparation work for third_party/openh264 build-from-src CL

This CL reverts https://codereview.chromium.org/1394983003/ which added dummy
unittest binaries for openh264.
This was decided to be a bad move (overhead of binaries, only wanting the tests
if flag is set). The unittests will be placed and implemented in
content_unittests instead in a follow-up CL.

This CL also pulls in openh264/src source code. The building of this and test
code will be added in a follow-up CL.

BUG=500605, 468365
==========

[hbos_chromium, 2015-11-10 16:33:24]

hbos@chromium.org changed reviewers:
+ dpranke@chromium.org, phoglund@chromium.org

[hbos_chromium, 2015-11-10 16:33:25]

Please take a look dpranke, phoglund.

[hbos_chromium, 2015-11-11 10:44:58]

Description was changed from

==========
Preparation work for third_party/openh264 build-from-src CL

This CL reverts https://codereview.chromium.org/1394983003/ which added dummy
unittest binaries for openh264.
This was decided to be a bad move (overhead of binaries, only wanting the tests
if flag is set). The unittests will be placed and implemented in
content_unittests instead in a follow-up CL.

This CL also pulls in openh264/src source code. The building of this and test
code will be added in a follow-up CL.

BUG=500605, 468365
==========

to

==========
Preparation work for third_party/openh264 build-from-src CL

This CL reverts the parts of https://codereview.chromium.org/1394983003/ that
added dummy unittest binaries for openh264.
This was decided to be a bad move (overhead of binaries, only wanting the tests
if flag is set). The unittests will be placed and implemented in
content_unittests instead in a follow-up CL.

This CL also pulls in openh264/src source code. The building of this and test
code will be added in a follow-up CL.

BUG=500605, 468365
==========

[phoglund_chromium, 2015-11-11 11:32:26]

lgtm

[hbos_chromium, 2015-11-11 12:06:03]

Thanks. Please take a look dpranke.

I'll reupload my other CL on top of this one when this have landed.

[Dirk Pranke, 2015-11-11 22:39:51]

lgtm

[hbos_chromium, 2015-11-12 08:14:32]

The CQ bit was checked by hbos@chromium.org

[commit-bot: I haz the power, 2015-11-12 08:14:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438553002/20001

[commit-bot: I haz the power, 2015-11-12 08:22:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 08:22:19]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hbos_chromium, 2015-11-12 08:30:43]

hbos@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[hbos_chromium, 2015-11-12 08:30:43]

Oops, missing lgtm for checklicenses.py. phajdan can you take a look at this
file?

I'm adding third party code and it does not recognize its source licence
headers.

[Paweł Hajdan Jr., 2015-11-12 15:55:03]

https://codereview.chromium.org/1438553002/diff/20001/tools/checklicenses/che...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/1438553002/diff/20001/tools/checklicenses/che...
tools/checklicenses/checklicenses.py:461: 'third_party/openh264/src': [
Could you please file an upstream bug about missing license headers?

Some files do have proper license headers and our tooling recognizes them.
However, that's not the case for all files here.

I'd like to stress that despite the tool confusingly says "No copyright", what
we're actually interested in for Chromium are just license headers. It's NOT
necessary to have copyright headers.

It's also fine to proceed with this CL once upstream (not chromium) bug is on
file and added as a comment to the whitelist here.

$ ./third_party/devscripts/licensecheck.pl -r third_party/openh264/ | grep
UNKNOWN
third_party/openh264/src/testbin/CmdLineExample.sh: *No copyright* UNKNOWN
third_party/openh264/src/build/mktargets.py: *No copyright* UNKNOWN
third_party/openh264/src/build/mktargets.sh: *No copyright* UNKNOWN
third_party/openh264/src/autotest/unitTest/android/run_AutoTest_android.sh: *No
copyright* UNKNOWN
third_party/openh264/src/autotest/unitTest/ios/run_AutoTest_ios.sh: *No
copyright* UNKNOWN
third_party/openh264/src/autotest/unitTest/run_unitTest.sh: *No copyright*
UNKNOWN
third_party/openh264/src/autotest/performanceTest/android/run_AutoTest_android.sh:
*No copyright* UNKNOWN
third_party/openh264/src/autotest/performanceTest/ios/run_AutoTest_ios.sh: *No
copyright* UNKNOWN
third_party/openh264/src/autotest/performanceTest/parsePerfData.sh: *No
copyright* UNKNOWN
third_party/openh264/src/code-coverage.sh: *No copyright* UNKNOWN
third_party/openh264/src/docs/doxygen2rst.py: *No copyright* UNKNOWN
third_party/openh264/src/codec/build/android/dec/jni/myjni.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/codec/build/android/dec/src/com/wels/dec/WelsDecTest.java:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/android/enc/jni/myjni.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/codec/build/android/enc/src/com/wels/enc/WelsEncTest.java:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/Properties/AssemblyInfo.cs:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/App.xaml.cs: *No
copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/MainPage.xaml.cs:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/LocalizedStrings.cs:
*No copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecRTComponent.h: *No
copyright* UNKNOWN
third_party/openh264/src/codec/build/windowsphone/all/CodecRTComponent.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/codec/common/generate_version.sh: *No copyright*
UNKNOWN
third_party/openh264/src/codec/common/inc/version.h: *No copyright* UNKNOWN
third_party/openh264/src/codec/common/inc/deblocking_common.h: *No copyright*
UNKNOWN
third_party/openh264/src/codec/common/src/deblocking_common.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/run_Test.sh: *No copyright* UNKNOWN
third_party/openh264/src/test/processing/ProcessUT_VaaCalc.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/processing/ProcessUT_ScrollDetection.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/processing/ProcessUT_DownSample.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/processing/ProcessUT_AdaptiveQuantization.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/utils/InputStream.h: *No copyright* UNKNOWN
third_party/openh264/src/test/utils/HashFunctions.h: *No copyright* UNKNOWN
third_party/openh264/src/test/utils/FileInputStream.h: *No copyright* UNKNOWN
third_party/openh264/src/test/utils/DataGenerator.h: *No copyright* UNKNOWN
third_party/openh264/src/test/utils/BufferedData.h: *No copyright* UNKNOWN
third_party/openh264/src/test/build/android/jni/codec_unittest.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/build/android/src/com/cisco/codec/unittest/MainActivity.java:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/ViewController.m:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/ViewController.h:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/AppDelegate.m:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/main.m:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/AppDelegate.h:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/Properties/AssemblyInfo.cs:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/App.xaml.cs:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/MainPage.xaml.cs:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/LocalizedStrings.cs:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/Codec_UT_RTComponent.h:
*No copyright* UNKNOWN
third_party/openh264/src/test/build/windowsphone/codec_ut/Codec_UT_RTComponent.cpp:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/run_PrepareAllTestData.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_ParseYUVInfo.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_SafeDelete.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_BitStreamToYUV.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_BinarySHA1Comparison.sh:
*No copyright* UNKNOWN
third_party/openh264/src/test/encoder_binary_comparison/run_Main.sh: *No
copyright* UNKNOWN
third_party/openh264/src/test/decoder/DecUT_IdctResAddPred.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_ErrorConcealment.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_DecExt.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/decoder/DecUT_DeblockCommon.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_ParseSyntax.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_Deblock.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/decoder/DecUT_IntraPrediction.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/decoder/DecUT_PredMv.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MotionCompensation.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_ExpGolomb.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_ParameterSetStrategy.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_Sample.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MotionEstimate.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MBCopy.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_DecodeMbAux.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_GetIntraPredictor.cpp: *No
copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_EncoderMb.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_EncoderMbAux.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_SVC_me.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/encoder/EncUT_InterfaceTest.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MemoryAlloc.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_MemoryZero.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_EncoderExt.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/encoder/EncUT_Reconstruct.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/api/simple_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/decoder_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/encoder_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/BaseEncoderTest.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/encode_decode_api_test.cpp: *No copyright*
UNKNOWN
third_party/openh264/src/test/api/c_interface_test.c: *No copyright* UNKNOWN
third_party/openh264/src/test/api/BaseDecoderTest.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/cpp_interface_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/DataGenerator.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/api/decode_encode_test.cpp: *No copyright* UNKNOWN
third_party/openh264/src/test/BaseEncoderTest.h: *No copyright* UNKNOWN
third_party/openh264/src/test/BaseDecoderTest.h: *No copyright* UNKNOWN
third_party/openh264/src/test/test_stdint.h: *No copyright* UNKNOWN
third_party/openh264/src/test/common/ExpandPicture.cpp: *No copyright* UNKNOWN

[hbos_chromium, 2015-11-13 10:43:50]

Please take another look phajdan :) created upstream bug

https://codereview.chromium.org/1438553002/diff/20001/tools/checklicenses/che...
File tools/checklicenses/checklicenses.py (right):

https://codereview.chromium.org/1438553002/diff/20001/tools/checklicenses/che...
tools/checklicenses/checklicenses.py:461: 'third_party/openh264/src': [
On 2015/11/12 15:55:03, Paweł Hajdan Jr. wrote:
> Could you please file an upstream bug about missing license headers?
> 
> Some files do have proper license headers and our tooling recognizes them.
> However, that's not the case for all files here.
> 
> I'd like to stress that despite the tool confusingly says "No copyright", what
> we're actually interested in for Chromium are just license headers. It's NOT
> necessary to have copyright headers.
> 
> It's also fine to proceed with this CL once upstream (not chromium) bug is on
> file and added as a comment to the whitelist here.
> 
> $ ./third_party/devscripts/licensecheck.pl -r third_party/openh264/ | grep
> UNKNOWN
> third_party/openh264/src/testbin/CmdLineExample.sh: *No copyright* UNKNOWN
> third_party/openh264/src/build/mktargets.py: *No copyright* UNKNOWN
> third_party/openh264/src/build/mktargets.sh: *No copyright* UNKNOWN
> third_party/openh264/src/autotest/unitTest/android/run_AutoTest_android.sh:
*No
> copyright* UNKNOWN
> third_party/openh264/src/autotest/unitTest/ios/run_AutoTest_ios.sh: *No
> copyright* UNKNOWN
> third_party/openh264/src/autotest/unitTest/run_unitTest.sh: *No copyright*
> UNKNOWN
>
third_party/openh264/src/autotest/performanceTest/android/run_AutoTest_android.sh:
> *No copyright* UNKNOWN
> third_party/openh264/src/autotest/performanceTest/ios/run_AutoTest_ios.sh: *No
> copyright* UNKNOWN
> third_party/openh264/src/autotest/performanceTest/parsePerfData.sh: *No
> copyright* UNKNOWN
> third_party/openh264/src/code-coverage.sh: *No copyright* UNKNOWN
> third_party/openh264/src/docs/doxygen2rst.py: *No copyright* UNKNOWN
> third_party/openh264/src/codec/build/android/dec/jni/myjni.cpp: *No copyright*
> UNKNOWN
>
third_party/openh264/src/codec/build/android/dec/src/com/wels/dec/WelsDecTest.java:
> *No copyright* UNKNOWN
> third_party/openh264/src/codec/build/android/enc/jni/myjni.cpp: *No copyright*
> UNKNOWN
>
third_party/openh264/src/codec/build/android/enc/src/com/wels/enc/WelsEncTest.java:
> *No copyright* UNKNOWN
>
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/Properties/AssemblyInfo.cs:
> *No copyright* UNKNOWN
> third_party/openh264/src/codec/build/windowsphone/all/CodecApp/App.xaml.cs:
*No
> copyright* UNKNOWN
>
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/MainPage.xaml.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/codec/build/windowsphone/all/CodecApp/LocalizedStrings.cs:
> *No copyright* UNKNOWN
> third_party/openh264/src/codec/build/windowsphone/all/CodecRTComponent.h: *No
> copyright* UNKNOWN
> third_party/openh264/src/codec/build/windowsphone/all/CodecRTComponent.cpp:
*No
> copyright* UNKNOWN
> third_party/openh264/src/codec/common/generate_version.sh: *No copyright*
> UNKNOWN
> third_party/openh264/src/codec/common/inc/version.h: *No copyright* UNKNOWN
> third_party/openh264/src/codec/common/inc/deblocking_common.h: *No copyright*
> UNKNOWN
> third_party/openh264/src/codec/common/src/deblocking_common.cpp: *No
copyright*
> UNKNOWN
> third_party/openh264/src/run_Test.sh: *No copyright* UNKNOWN
> third_party/openh264/src/test/processing/ProcessUT_VaaCalc.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/processing/ProcessUT_ScrollDetection.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/processing/ProcessUT_DownSample.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/processing/ProcessUT_AdaptiveQuantization.cpp:
*No
> copyright* UNKNOWN
> third_party/openh264/src/test/utils/InputStream.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/utils/HashFunctions.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/utils/FileInputStream.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/utils/DataGenerator.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/utils/BufferedData.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/build/android/jni/codec_unittest.cpp: *No
> copyright* UNKNOWN
>
third_party/openh264/src/test/build/android/src/com/cisco/codec/unittest/MainActivity.java:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/ViewController.m:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/ViewController.h:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/AppDelegate.m:
> *No copyright* UNKNOWN
> third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/main.m:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/ios/codec_unittest/codec_unittest/AppDelegate.h:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/Properties/AssemblyInfo.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/App.xaml.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/MainPage.xaml.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/CodecUTApp/LocalizedStrings.cs:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/Codec_UT_RTComponent.h:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/build/windowsphone/codec_ut/Codec_UT_RTComponent.cpp:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/run_PrepareAllTestData.sh:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_ParseYUVInfo.sh:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_SafeDelete.sh:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_BitStreamToYUV.sh:
> *No copyright* UNKNOWN
>
third_party/openh264/src/test/encoder_binary_comparison/Scripts/run_BinarySHA1Comparison.sh:
> *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder_binary_comparison/run_Main.sh: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_IdctResAddPred.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_ErrorConcealment.cpp: *No
copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_DecExt.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_DeblockCommon.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_ParseSyntax.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_Deblock.cpp: *No copyright*
UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_IntraPrediction.cpp: *No
copyright*
> UNKNOWN
> third_party/openh264/src/test/decoder/DecUT_PredMv.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MotionCompensation.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_ExpGolomb.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_ParameterSetStrategy.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_Sample.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MotionEstimate.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MBCopy.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_DecodeMbAux.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_GetIntraPredictor.cpp: *No
> copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_EncoderMb.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_EncoderMbAux.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_SVC_me.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_InterfaceTest.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MemoryAlloc.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_MemoryZero.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_EncoderExt.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/encoder/EncUT_Reconstruct.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/api/simple_test.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/decoder_test.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/encoder_test.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/BaseEncoderTest.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/encode_decode_api_test.cpp: *No copyright*
> UNKNOWN
> third_party/openh264/src/test/api/c_interface_test.c: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/BaseDecoderTest.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/cpp_interface_test.cpp: *No copyright*
UNKNOWN
> third_party/openh264/src/test/api/DataGenerator.cpp: *No copyright* UNKNOWN
> third_party/openh264/src/test/api/decode_encode_test.cpp: *No copyright*
UNKNOWN
> third_party/openh264/src/test/BaseEncoderTest.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/BaseDecoderTest.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/test_stdint.h: *No copyright* UNKNOWN
> third_party/openh264/src/test/common/ExpandPicture.cpp: *No copyright* UNKNOWN

Ack. Created an upstream bug and added a comment linking to it.

[Paweł Hajdan Jr., 2015-11-13 12:40:06]

checklicenses LGTM

[hbos_chromium, 2015-11-13 13:00:31]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2015-11-13 13:00:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, phoglund@chromium.org
Link to the patchset: https://codereview.chromium.org/1438553002/#ps40001
(title: "Added comment with link to openh264 bug about missing license headers")

[commit-bot: I haz the power, 2015-11-13 13:00:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438553002/40001

[commit-bot: I haz the power, 2015-11-13 13:02:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 13:02:07]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[hbos_chromium, 2015-11-13 13:32:03]

The CQ bit was checked by hbos@chromium.org

[hbos_chromium, 2015-11-13 13:32:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, phoglund@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/1438553002/#ps60001
(title: "Rebase with master")

[commit-bot: I haz the power, 2015-11-13 13:32:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438553002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438553002/60001

[commit-bot: I haz the power, 2015-11-13 14:44:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-13 14:44:56]

Patchset 4 (id:??) landed as
https://crrev.com/dc28e3ffd89faa7cf1a38ca63084685186534108
Cr-Commit-Position: refs/heads/master@{#359548}