Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Unified Diff: pkg/compiler/lib/src/common/resolution.dart

Issue 1438453002: Use Feature directly in resolution. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/common/resolution.dart
diff --git a/pkg/compiler/lib/src/common/resolution.dart b/pkg/compiler/lib/src/common/resolution.dart
index 633454b2a50711929ea1e9ef6173849d2b5cce73..727f3aa8632f19128a7d4b16302b1c02ff4dd192 100644
--- a/pkg/compiler/lib/src/common/resolution.dart
+++ b/pkg/compiler/lib/src/common/resolution.dart
@@ -8,6 +8,8 @@ library dart2js.common.resolution;
import '../common.dart';
import '../compiler.dart' show
Compiler;
+import '../constants/expressions.dart' show
+ ConstantExpression;
import '../core_types.dart' show
CoreTypes;
import '../dart_types.dart' show
@@ -59,15 +61,13 @@ class ResolutionWorkItem extends WorkItem {
class ResolutionImpact extends WorldImpact {
const ResolutionImpact();
- // TODO(johnniwinther): Remove this.
- void registerDependency(Element element) {}
-
Iterable<Feature> get features => const <Feature>[];
- Iterable<DartType> get requiredTypes => const <DartType>[];
Iterable<MapLiteralUse> get mapLiterals => const <MapLiteralUse>[];
Iterable<ListLiteralUse> get listLiterals => const <ListLiteralUse>[];
- Iterable<DartType> get typeLiterals => const <DartType>[];
Iterable<String> get constSymbolNames => const <String>[];
+ Iterable<ConstantExpression> get constantLiterals {
+ return const <ConstantExpression>[];
+ }
}
/// A language feature seen during resolution.
@@ -99,6 +99,8 @@ enum Feature {
STACK_TRACE_IN_CATCH,
/// String interpolation.
STRING_INTERPOLATION,
+ /// String juxtaposition.
+ STRING_JUXTAPOSITION,
/// An implicit call to `super.noSuchMethod`, like calling an unresolved
/// super method.
SUPER_NO_SUCH_METHOD,
« no previous file with comments | « no previous file | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698