Port placeholders logic GYP->GN

Port placeholders logic GYP->GN

BUG=535390, 384638
Committed: https://crrev.com/2b9cc87893cdf97eca6ed44224783cea84d469d3
Cr-Commit-Position: refs/heads/master@{#359944}

[agrieve, 2015-11-14 00:00:11]

Description was changed from

==========
Port placeholders logic GYP->GN

BUG=535390,384638
==========

to

==========
Port placeholders logic GYP->GN

BUG=535390,384638
==========

[agrieve, 2015-11-14 00:00:11]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[agrieve, 2015-11-14 00:00:28]

On 2015/11/14 00:00:11, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pkotwicz@chromium.org

ptal

[pkotwicz, 2015-11-16 19:28:22]

LGTM with nits

https://codereview.chromium.org/1438413004/diff/1/build/android/gyp/apkbuilde...
File build/android/gyp/apkbuilder.py (right):

https://codereview.chromium.org/1438413004/diff/1/build/android/gyp/apkbuilde...
build/android/gyp/apkbuilder.py:149: apk.writestr('lib/%s/%s' %
(options.android_abi, name), ':)',
:-)

https://codereview.chromium.org/1438413004/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1438413004/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:913: native_lib_placeholders = [
"libfix.crbug.384638.so" ]
I think that GYP appends "libfix.crbug.384638.so" to |native_lib_placeholders|

https://codereview.chromium.org/1438413004/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1438413004/diff/1/build/config/android/rules....
build/config/android/rules.gni:1662: # bother to create them in the case of
splits.
Can you mention the relevant bug in the comment? I think that
http://crbug.com/395038 is the correct bug

https://codereview.chromium.org/1438413004/diff/1/build/config/android/rules....
build/config/android/rules.gni:1663: forward_variables_from(invoker, [
"native_lib_placeholders" ])
Nit: new line

[agrieve, 2015-11-16 19:45:15]

https://codereview.chromium.org/1438413004/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1438413004/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:913: native_lib_placeholders = [
"libfix.crbug.384638.so" ]
On 2015/11/16 19:28:22, pkotwicz wrote:
> I think that GYP appends "libfix.crbug.384638.so" to |native_lib_placeholders|

I think that may have just been out of convenience. For the managed install
case, you just need a non-zero number of libs to exist.

https://codereview.chromium.org/1438413004/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1438413004/diff/1/build/config/android/rules....
build/config/android/rules.gni:1662: # bother to create them in the case of
splits.
On 2015/11/16 19:28:22, pkotwicz wrote:
> Can you mention the relevant bug in the comment? I think that
> http://crbug.com/395038 is the correct bug

Done.

https://codereview.chromium.org/1438413004/diff/1/build/config/android/rules....
build/config/android/rules.gni:1663: forward_variables_from(invoker, [
"native_lib_placeholders" ])
On 2015/11/16 19:28:22, pkotwicz wrote:
> Nit: new line

Done.

[agrieve, 2015-11-16 19:45:20]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-11-16 19:45:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/1438413004/#ps20001
(title: "review1")

[commit-bot: I haz the power, 2015-11-16 19:46:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438413004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438413004/20001

[commit-bot: I haz the power, 2015-11-16 20:01:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-16 20:02:00]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[agrieve, 2015-11-16 21:19:53]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-11-16 21:19:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/1438413004/#ps40001
(title: "fix assert")

[commit-bot: I haz the power, 2015-11-16 21:21:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438413004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438413004/40001

[commit-bot: I haz the power, 2015-11-16 22:45:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-16 22:46:54]

Patchset 3 (id:??) landed as
https://crrev.com/2b9cc87893cdf97eca6ed44224783cea84d469d3
Cr-Commit-Position: refs/heads/master@{#359944}