Source/modules/notifications/Notification.idl - Issue 14384004: Get rid of [Callback] extended attribute for parameters in IDL files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/notifications/Notification.idl

Issue 14384004: Get rid of [Callback] extended attribute for parameters in IDL files (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/CodeGeneratorV8.pm ('K') | « Source/modules/mediastream/RTCPeerConnection.idl ('k') | Source/modules/notifications/NotificationCenter.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/notifications/Notification.idl

diff --git a/Source/modules/notifications/Notification.idl b/Source/modules/notifications/Notification.idl

index 42c8b688ac1eb64e8e887039866dab40a33d3000..22b76f5bc55fe7c49893a6e3da7bc4334c7d48ab 100644

--- a/Source/modules/notifications/Notification.idl

+++ b/Source/modules/notifications/Notification.idl

@@ -50,7 +50,7 @@

#if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS

[CallWith=ScriptExecutionContext] static readonly attribute DOMString permission;

- [CallWith=ScriptExecutionContext] static void requestPermission([Callback] optional NotificationPermissionCallback callback);

+ [CallWith=ScriptExecutionContext] static void requestPermission(optional NotificationPermissionCallback callback);

#endif

attribute EventListener onshow;