Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1438313003: mac: Remove vestiges of 32-bit deprecation (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
Greg K
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove vestiges of 32-bit deprecation 32-bit support was dropped in Chrome 39, a year ago. It seems like a good time to stop carrying this stuff around. Committed: https://crrev.com/c5af6de2b6499645244d173f841b4013f3c60a56 Cr-Commit-Position: refs/heads/master@{#360153}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -125 lines) Patch
M build/mac/tweak_info_plist.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/mac/keystone_glue.mm View 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/installer/mac/keystone_install.sh View 1 6 chunks +1 line, -118 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Mentovai
Greg, the only other OWNER in these directories is thomasvl, but he hasn’t been on ...
5 years, 1 month ago (2015-11-12 23:10:48 UTC) #2
Greg K
On 2015/11/12 23:10:48, Mark Mentovai wrote: > Greg, the only other OWNER in these directories ...
5 years, 1 month ago (2015-11-13 23:33:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438313003/20001
5 years, 1 month ago (2015-11-17 20:10:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-17 20:39:16 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 20:40:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5af6de2b6499645244d173f841b4013f3c60a56
Cr-Commit-Position: refs/heads/master@{#360153}

Powered by Google App Engine
This is Rietveld 408576698