Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1438313002: [heap] Fix type conversion in gc tracer (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix type conversion in gc tracer R=hpayer@chromium.org Committed: https://crrev.com/ccae6b51a1f21639024b84b064af1ba0ae1ae887 Cr-Commit-Position: refs/heads/master@{#31970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/heap/gc-tracer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438313002/1
5 years, 1 month ago (2015-11-12 19:15:23 UTC) #3
Michael Lippautz
5 years, 1 month ago (2015-11-12 19:15:30 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-12 19:17:03 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 19:39:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438313002/1
5 years, 1 month ago (2015-11-12 19:40:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 19:41:48 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ccae6b51a1f21639024b84b064af1ba0ae1ae887
Cr-Commit-Position: refs/heads/master@{#31970}

Powered by Google App Engine
This is Rietveld 408576698