masters/master.client.skia/master_site_config.py - Issue 14383021: Break config_default into master_site_configs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: masters/master.client.skia/master_site_config.py

Issue 14383021: Break config_default into master_site_configs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 """ActiveMaster definition."""

	6

	7 import socket

	8 from config import Master

	9

	10 class Skia(Master.Master3):

	11 project_name = 'Skia'

	12 master_port = 8041

	13 slave_port = 8141

	14 master_port_alt = 8241

	15 server_url = 'http://skia.googlecode.com'

	16 project_url = 'http://skia.googlecode.com'

	17 production_host = None

	18 is_production_host = socket.getfqdn() == production_host
	Isaac (away) 2013/04/29 01:27:57 can line 17/18 be simplified to: is_production_ho can line 17/18 be simplified to: is_production_host = False ? Is it possible to put these lines in a base class? agable 2013/04/29 17:40:20 The Skia config is kinda a special case, since it Show quoted text On 2013/04/29 01:27:57, Isaac wrote: > can line 17/18 be simplified to: is_production_host = False ? > > Is it possible to put these lines in a base class? The Skia config is kinda a special case, since it is really just a stub (due to skia maintaining their own buildbot master in the skia repo). But yes, I'll also force is_production_host to False and add a comment explaining that it is a stub.
OLD	NEW