Break config_default into master_site_configs.

masters/master.chromium.chrome/master.cfg

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from buildbot.changes import svnpoller
 from buildbot.scheduler import Scheduler
 
 # These modules come from scripts/master, which must be in the PYTHONPATH.
 from master import build_utils
 from master import master_utils
 from master import slaves_list
 
 from master.factory import chromium_factory
 
 # These modules come from scripts/common, which must be in the PYTHONPATH.
 import config

[Isaac (away), 2013/04/29 01:27:57]

This existing master_site_configs (like master.chromium.linux) extend from
Object instead of from a config base class.  But since the new ones extend from
config, do we need to refer to the config module directly rather than through
ActiveMaster object?

[agable, 2013/04/29 17:40:20]

The existing master_site_configs have been changed to inherit from config base
classes. That said, the master_site_configs do "from config import Master", so
we can't actually access config through them. In the spirit of having this
change be as minimally invasive as possible, I'd rather leave the 'import
configs' here, and fix those later when I move Archive and DatabaseSetup out of
config.

+import master_site_config
 
-ActiveMaster = config.Master.ChromiumChrome
+ActiveMaster = master_site_config.ChromiumChrome
 
 # This is the dictionary that the buildmaster pays attention to. We also use
 # a shorter alias to save typing.
 c = BuildmasterConfig = {}
 
 config.DatabaseSetup(c, require_dbconfig=ActiveMaster.is_production_host)
 
 ####### CHANGESOURCES
 
 # the 'change_source' list tells the buildmaster how it should find out about
@@ skipping 251 matching lines @@
 # Adds common status and tools to this master.
 master_utils.AutoSetupMaster(c, ActiveMaster,
     public_html='../master.chromium/public_html',
     templates=['../master.chromium/templates'],
     enable_http_status_push=ActiveMaster.is_production_host)
 
 ####### PROJECT IDENTITY
 
 # Buildbot master url:
 c['buildbotURL'] = 'http://build.chromium.org/buildbot/chromium.chrome/'