Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 14383003: Application shortcuts in Linux are now installed into a "Chrome Apps" folder. (Closed)

Created:
7 years, 8 months ago by Matt Giuca
Modified:
7 years, 7 months ago
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, saroop
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Application shortcuts in Linux are now installed into a "Chrome Apps" folder. Previously they were not put into a folder, so they would simply be placed under the "Other" menu in Gnome 2. This change does not affect URL shortcuts. BUG=234041 TEST=Create shortcut in Applications Menu for Chrome app; in Gnome 2, should appear in "Chromium Apps" menu. TEST=Create shortcut in Start Menu for URL; in Gnome 2, should appear in "Other" menu. TEST=Uninstall Chrome app; should delete shortcut from Chromium Apps menu. If the app is the last shortcut in the menu, should delete menu. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197907

Patch Set 1 #

Patch Set 2 : Rebase against Issue 14209008. #

Patch Set 3 : Don't put URL apps in the Chrome Apps folder. #

Patch Set 4 : Rebase to HEAD. Much simpler now that equivalent Windows patch has gone through. #

Patch Set 5 : Rebase against Issue 14209008. #

Patch Set 6 : GetDirectoryFileContents needs the same \n hack as GetDesktopFileContents. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -6 lines) Patch
M chrome/browser/shell_integration_linux.h View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 2 3 4 5 9 chunks +84 lines, -6 lines 0 comments Download
M chrome/browser/shell_integration_unittest.cc View 1 2 3 4 5 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 1 2 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Matt Giuca
Hi reviewers, Same as the Windows one (https://codereview.chromium.org/14533004) but for Linux.
7 years, 7 months ago (2013-04-29 05:36:45 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 7 months ago (2013-04-29 16:11:21 UTC) #2
Matt Giuca
On 2013/04/29 16:11:21, Ben Goodger (Google) wrote: > lgtm Thanks, Ben. Ben Wells, could you ...
7 years, 7 months ago (2013-04-30 06:59:48 UTC) #3
Sam McNally
lgtm
7 years, 7 months ago (2013-05-01 03:33:38 UTC) #4
benwells
On 2013/05/01 03:33:38, Sam McNally wrote: > lgtm lgtm
7 years, 7 months ago (2013-05-01 09:15:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/14383003/19006
7 years, 7 months ago (2013-05-02 10:06:43 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-02 13:16:07 UTC) #7
Message was sent while issue was closed.
Change committed as 197907

Powered by Google App Engine
This is Rietveld 408576698