Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1438293002: Server notification to indicate `pub list-dir` fallback. (Closed)

Created:
5 years, 1 month ago by pquitslund
Modified:
5 years, 1 month ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Server notification to indicate `pub list-dir` fallback. For diagnostic purposes. See: https://github.com/dart-lang/sdk/issues/24900 for more context. BUG=24900 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4680736a8f93ba3db865bda45d4768a086b43e39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 1 month ago (2015-11-12 19:07:31 UTC) #2
Brian Wilkerson
LGTM. Don't forget to cherry pick this one.
5 years, 1 month ago (2015-11-12 19:14:02 UTC) #3
jwren
On 2015/11/12 19:14:02, Brian Wilkerson wrote: > LGTM. Don't forget to cherry pick this one. ...
5 years, 1 month ago (2015-11-12 19:32:41 UTC) #4
pquitslund
5 years, 1 month ago (2015-11-12 21:24:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4680736a8f93ba3db865bda45d4768a086b43e39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698