Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1438233002: [proxies] Teach ToPropertyDescriptor to deal with Proxies (Closed)

Created:
5 years, 1 month ago by Jakob Kummerow
Modified:
5 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
neis, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Teach ToPropertyDescriptor to deal with Proxies BUG=v8:1543 LOG=n Committed: https://crrev.com/d001cd5665a54abcecddaf2ad0a4658e41ab22af Cr-Commit-Position: refs/heads/master@{#31962}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -103 lines) Patch
M src/property-descriptor.h View 2 chunks +11 lines, -5 lines 0 comments Download
M src/property-descriptor.cc View 2 chunks +130 lines, -98 lines 4 comments Download
M src/runtime/runtime-object.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jakob Kummerow
Camillo, PTAL. Georg, FYI. https://codereview.chromium.org/1438233002/diff/1/src/property-descriptor.cc File src/property-descriptor.cc (right): https://codereview.chromium.org/1438233002/diff/1/src/property-descriptor.cc#newcode163 src/property-descriptor.cc:163: // enumerable? This is the ...
5 years, 1 month ago (2015-11-12 13:44:46 UTC) #2
Camillo Bruni
lgtm https://codereview.chromium.org/1438233002/diff/1/src/property-descriptor.cc File src/property-descriptor.cc (right): https://codereview.chromium.org/1438233002/diff/1/src/property-descriptor.cc#newcode19 src/property-descriptor.cc:19: bool GetPropertyIfPresent(Handle<Object> obj, Handle<String> name, Probably this will ...
5 years, 1 month ago (2015-11-12 13:52:19 UTC) #3
Jakob Kummerow
Thanks, landing. https://codereview.chromium.org/1438233002/diff/1/src/property-descriptor.cc File src/property-descriptor.cc (right): https://codereview.chromium.org/1438233002/diff/1/src/property-descriptor.cc#newcode19 src/property-descriptor.cc:19: bool GetPropertyIfPresent(Handle<Object> obj, Handle<String> name, On 2015/11/12 ...
5 years, 1 month ago (2015-11-12 14:01:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438233002/1
5 years, 1 month ago (2015-11-12 14:01:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 14:17:41 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:20:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d001cd5665a54abcecddaf2ad0a4658e41ab22af
Cr-Commit-Position: refs/heads/master@{#31962}

Powered by Google App Engine
This is Rietveld 408576698