Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 143823016: Remove unused SampleTests.cpp source file. (Closed)

Created:
6 years, 11 months ago by tfarina
Modified:
6 years, 11 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove unused SampleTests.cpp source file. We never compile this file. BUG=None TEST=tests R=reed@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=13157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -119 lines) Patch
M gyp/SampleApp.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D samplecode/SampleTests.cpp View 1 chunk +0 lines, -117 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
is this ok? Would be useful to get it compiling and running on SampleApp?
6 years, 11 months ago (2014-01-23 02:31:58 UTC) #1
robertphillips
lgtm but adding someone who might know this file's history.
6 years, 11 months ago (2014-01-23 14:05:52 UTC) #2
reed1
lgtm
6 years, 11 months ago (2014-01-23 14:11:19 UTC) #3
tfarina
6 years, 11 months ago (2014-01-23 21:30:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r13157 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698