LayoutTests/fast/dom/DeviceLight/create-event.html - Issue 143823004: Implement DeviceLight

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/DeviceLight/create-event.html

Issue 143823004: Implement DeviceLight (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase after r172920 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>
	Inactive 2014/05/06 12:58:08 Missing DOCTYPE Missing DOCTYPE riju_ 2014/05/09 12:00:21 Done. Show quoted text On 2014/05/06 12:58:08, Chris Dumez wrote: > Missing DOCTYPE Done.
	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 </head>

	5 <body>

	6 <script>

	7 description("Tests that document.createEvent() works with DeviceLightEvent.");

	8

	9 var event = document.createEvent('DeviceLightEvent');
	Inactive 2014/05/06 12:58:08 It would be good to test the modern way of creatin It would be good to test the modern way of creating events too (DeviceLightEvent constructor). riju_ 2014/05/09 12:00:21 Done. Show quoted text On 2014/05/06 12:58:08, Chris Dumez wrote: > It would be good to test the modern way of creating events too (DeviceLightEvent > constructor). Done.
	10
	Inactive 2014/05/06 12:58:08 shouldBe("event.__proto__", "DeviceLightEvent.prot shouldBe("event.__proto__", "DeviceLightEvent.prototype"); riju_ 2014/05/09 12:00:21 Done. Show quoted text On 2014/05/06 12:58:08, Chris Dumez wrote: > shouldBe("event.__proto__", "DeviceLightEvent.prototype"); Done.
	11 shouldBeTrue("typeof event == 'object'");

	12

	13 shouldBeTrue("'type' in event");

	14 shouldBeTrue("'bubbles' in event");

	15 shouldBeTrue("'cancelable' in event");

	16 shouldBeTrue("'value' in event");

	17

	18 shouldBeTrue("typeof event.type == 'string'");
	Inactive 2014/05/06 12:58:08 You should also check that type is "devicelight". You should also check that type is "devicelight". riju_ 2014/05/09 12:00:21 Done. Show quoted text On 2014/05/06 12:58:08, Chris Dumez wrote: > You should also check that type is "devicelight". Done.
	19 shouldBeTrue("typeof event.bubbles == 'boolean'");
	Inactive 2014/05/06 12:58:08 You should also check that bubbles is true. You should also check that bubbles is true. riju_ 2014/05/09 12:00:21 Done. Show quoted text On 2014/05/06 12:58:08, Chris Dumez wrote: > You should also check that bubbles is true. Done.
	20 shouldBeTrue("typeof event.cancelable == 'boolean'");
	Inactive 2014/05/06 12:58:08 You should also check that cancelable is false. You should also check that cancelable is false. riju_ 2014/05/09 12:00:21 Done. Show quoted text On 2014/05/06 12:58:08, Chris Dumez wrote: > You should also check that cancelable is false. Done.
	21 shouldBeTrue("typeof event.value == 'number'");
	Inactive 2014/05/06 12:58:08 You should check the value as well. You should check the value as well. riju_ 2014/05/09 12:00:21 Done. Show quoted text On 2014/05/06 12:58:08, Chris Dumez wrote: > You should check the value as well. Done.
	22 </script>

	23 </body>

	24 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/DeviceLight/create-event-expected.txt » ('j') | Source/modules/device_light/DeviceLightEvent.cpp » ('J')