Implement DeviceLight

Source/modules/device_light/DeviceLightController.cpp

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "modules/device_light/DeviceLightController.h"
+
+#include "RuntimeEnabledFeatures.h"
+#include "core/dom/Document.h"
+#include "core/page/Page.h"
+#include "modules/device_light/DeviceLightDispatcher.h"
+#include "modules/device_light/DeviceLightEvent.h"
+
+namespace WebCore {
+
+DeviceLightController::DeviceLightController(Document& document)
+    : DeviceSensorEventController(document)
+    , DOMWindowLifecycleObserver(document.domWindow())
+{
+}
+
+DeviceLightController::~DeviceLightController()
+{
+    stopUpdating();
+}
+
+void DeviceLightController::didChangeDeviceLight(double value)
+{
+    dispatchDeviceEvent(DeviceLightEvent::create(EventTypeNames::devicelight, value));
+}
+
+const char* DeviceLightController::supplementName()
+{
+    return "DeviceLightController";
+}
+
+DeviceLightController& DeviceLightController::from(Document& document)
+{
+    DeviceLightController* controller = static_cast<DeviceLightController*>(DocumentSupplement::from(document, supplementName()));
+    if (!controller) {
+        controller = new DeviceLightController(document);
+        DocumentSupplement::provideTo(document, supplementName(), adoptPtr(controller));
+    }
+    return *controller;
+}
+
+bool DeviceLightController::hasLastData()
+{
+    return (DeviceLightDispatcher::instance().latestDeviceLightData() >= 0 ) ? true : false;

[Inactive, 2014/04/15 15:56:12]

return DeviceLightDispatcher::instance().latestDeviceLightData() >= 0;

[riju_, 2014/04/22 13:11:29]

Done.

+}
+
+PassRefPtrWillBeRawPtr<Event> DeviceLightController::getLastEvent()
+{
+    return DeviceLightEvent::create(EventTypeNames::devicelight,
+        DeviceLightDispatcher::instance().latestDeviceLightData());
+}
+
+void DeviceLightController::registerWithDispatcher()
+{
+    DeviceLightDispatcher::instance().addDeviceLightController(this);
+}
+
+void DeviceLightController::unregisterWithDispatcher()
+{
+    DeviceLightDispatcher::instance().removeDeviceLightController(this);
+}
+
+bool DeviceLightController::isNullEvent(Event* event)
+{
+    DeviceLightEvent* lightEvent = toDeviceLightEvent(event);
+    return (lightEvent->value() == std::numeric_limits<double>::infinity()) ? true : false;

[Inactive, 2014/04/15 15:56:12]

return lightEvent->value() == std::numeric_limits<double>::infinity();

[riju_, 2014/04/22 13:11:29]

Done.

+}
+
+void DeviceLightController::didAddEventListener(DOMWindow* window, const AtomicString& eventType)
+{
+    if (eventType == EventTypeNames::devicelight && RuntimeEnabledFeatures::deviceLightEnabled()) {
+        if (page() && page()->visibilityState() == PageVisibilityStateVisible)
+            startUpdating();
+        m_hasEventListener = true;
+    }
+}
+
+void DeviceLightController::didRemoveEventListener(DOMWindow* window, const AtomicString& eventType)
+{
+    if (eventType == EventTypeNames::devicelight) {
+        stopUpdating();

[Inactive, 2014/04/15 15:56:12]

This is something that the DeviceOrientation code does but that I never
understood. What if we have several listeners from the 'devicelight' event? The
current code will stop listening as soon as 1 of the listeners is unregistered.
This does not seem right to me but it may simply be me misunderstanding.

I thought we should have a counter that we increment / decrement in didAdd /
didRemove and only stop listening when it becomes zero.

This is more a question for Tim or Adam I guess. Do not change this just yet as
this is consistent with device orientation / motion and I may be
misunderstanding.

[timvolodine, 2014/04/17 14:35:52]

Chris you are right, this is an issue indeed. It appears we can avoid keeping a
counter by simply testing
"window->hasEventListeners(EventTypeNames::devicemotion)" when adding/removing
listeners. I've uploaded https://codereview.chromium.org/240993003/ let me know
what you think.

[riju_, 2014/04/22 13:11:29]

Done.

+        m_hasEventListener = false;
+    }
+}
+
+void DeviceLightController::didRemoveAllEventListeners(DOMWindow* window)
+{
+    stopUpdating();
+    m_hasEventListener = false;
+}
+
+} // namespace WebCore