LayoutTests/fast/dom/DeviceLight/script-tests/create-event.js - Issue 143823004: Implement DeviceLight - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(39)

My Issues | Starred Open | Closed | All

Side by Side Diff: LayoutTests/fast/dom/DeviceLight/script-tests/create-event.js

Issue 143823004: Implement DeviceLight (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Event not Oilpan-ed yet. Add a test back Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/dom/DeviceLight/script-tests/TEMPLATE.html ('K') | « LayoutTests/fast/dom/DeviceLight/script-tests/TEMPLATE.html ('k') | LayoutTests/fast/dom/DeviceLight/script-tests/window-property.js » ('j') | Source/modules/device_light/DeviceLightController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 description("Tests that document.createEvent() works with DeviceLightEvent.");

	2

	3 var event = document.createEvent('DeviceLightEvent');

	4

	5 shouldBeTrue("typeof event == 'object'");

	6

	7 shouldBeTrue("'type' in event");

	8 shouldBeTrue("'bubbles' in event");

	9 shouldBeTrue("'cancelable' in event");

	10 shouldBeTrue("'value' in event");

	11

	12 shouldBeTrue("typeof event.type == 'string'");

	13 shouldBeTrue("typeof event.bubbles == 'boolean'");

	14 shouldBeTrue("typeof event.cancelable == 'boolean'");

	15 shouldBeTrue("typeof event.value == 'number'");
	abarth-chromium 2014/03/21 13:04:13 This code should be inlined into the test that use This code should be inlined into the test that uses it. Having a separate script-tests directory doesn't serve any purpose anymore. riju_ 2014/04/03 17:52:53 Done. Show quoted text On 2014/03/21 13:04:13, abarth wrote: > This code should be inlined into the test that uses it. Having a separate > script-tests directory doesn't serve any purpose anymore. Done.
OLD	NEW

« LayoutTests/fast/dom/DeviceLight/script-tests/TEMPLATE.html ('K') | « LayoutTests/fast/dom/DeviceLight/script-tests/TEMPLATE.html ('k') | LayoutTests/fast/dom/DeviceLight/script-tests/window-property.js » ('j') | Source/modules/device_light/DeviceLightController.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698