Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h

Issue 1438193002: Oilpan: move HTMLParserScheduler to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move the object to the heap instead Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h b/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
index bc967a414054bc98641c9b89c08048829fe7d33b..6e84756f1def821e6f53cec15d8578133e1f7fdf 100644
--- a/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.h
@@ -70,12 +70,13 @@ private:
size_t m_processedElementTokens;
};
-class HTMLParserScheduler {
- WTF_MAKE_NONCOPYABLE(HTMLParserScheduler); USING_FAST_MALLOC(HTMLParserScheduler);
+class HTMLParserScheduler final : public NoBaseWillBeGarbageCollectedFinalized<HTMLParserScheduler> {
+ WTF_MAKE_NONCOPYABLE(HTMLParserScheduler);
+ USING_FAST_MALLOC_WILL_BE_REMOVED(HTMLParserScheduler);
public:
- static PassOwnPtr<HTMLParserScheduler> create(HTMLDocumentParser* parser, WebTaskRunner* loadingTaskRunner)
+ static PassOwnPtrWillBeRawPtr<HTMLParserScheduler> create(HTMLDocumentParser* parser, WebTaskRunner* loadingTaskRunner)
{
- return adoptPtr(new HTMLParserScheduler(parser, loadingTaskRunner));
+ return adoptPtrWillBeNoop(new HTMLParserScheduler(parser, loadingTaskRunner));
}
~HTMLParserScheduler();
@@ -98,13 +99,15 @@ public:
void detach(); // Clear active tasks if any.
+ DECLARE_TRACE();
+
private:
HTMLParserScheduler(HTMLDocumentParser*, WebTaskRunner*);
bool shouldYield(const SpeculationsPumpSession&, bool startingScript) const;
void continueParsing();
- HTMLDocumentParser* m_parser;
+ RawPtrWillBeMember<HTMLDocumentParser> m_parser;
OwnPtr<WebTaskRunner> m_loadingTaskRunner;
OwnPtr<CancellableTaskFactory> m_cancellableContinueParse;

Powered by Google App Engine
This is Rietveld 408576698