Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1438173003: Merge to XFA: Fix typos in BUILD.gn. (Closed)

Created:
5 years, 1 month ago by Oliver Chang
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix typos in BUILD.gn. Accidentally reverted this while rebasing another CL. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1441473004 . (cherry picked from commit 4274ea205ca2219f6a4cfc54025284c1aa3b14b8) Committed: https://pdfium.googlesource.com/pdfium/+/d46f1c83038bbe05e5ad072f157b830b03706e8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Oliver Chang
clean merge, thanks for reminding. TBR
5 years, 1 month ago (2015-11-13 06:03:04 UTC) #1
Oliver Chang
Committed patchset #1 (id:1) manually as d46f1c83038bbe05e5ad072f157b830b03706e8b (presubmit successful).
5 years, 1 month ago (2015-11-13 06:03:14 UTC) #2
Lei Zhang
5 years, 1 month ago (2015-11-13 06:04:47 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698