Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: content/renderer/media/rtc_peer_connection_handler_unittest.cc

Issue 1438153002: Fix leak of RTCPeerConnectionHandler if PeerConnection.close() is called from js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_peer_connection_handler_unittest.cc
diff --git a/content/renderer/media/rtc_peer_connection_handler_unittest.cc b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
index 6cbdd1db986c06622a30e80969fa77bfff3495d4..88fad70aa2dde5224965d7ad792de5680fa03927 100644
--- a/content/renderer/media/rtc_peer_connection_handler_unittest.cc
+++ b/content/renderer/media/rtc_peer_connection_handler_unittest.cc
@@ -334,6 +334,11 @@ TEST_F(RTCPeerConnectionHandlerTest, Destruct) {
pc_handler_.reset(NULL);
}
+TEST_F(RTCPeerConnectionHandlerTest, DestructAllHandlers) {
+ EXPECT_CALL(*mock_client_.get(), releasePeerConnectionHandler())
+ .Times(1);
+ RTCPeerConnectionHandler::DestructAllHandlers();
+}
TEST_F(RTCPeerConnectionHandlerTest, CreateOffer) {
blink::WebRTCSessionDescriptionRequest request;
blink::WebMediaConstraints options;

Powered by Google App Engine
This is Rietveld 408576698