content/renderer/media/rtc_peer_connection_handler.h - Issue 1438153002: Fix leak of RTCPeerConnectionHandler if PeerConnection.close() is called from js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_peer_connection_handler.h

Issue 1438153002: Fix leak of RTCPeerConnectionHandler if PeerConnection.close() is called from js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simple unittest of DestructAllHandlers Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/rtc_peer_connection_handler.h

diff --git a/content/renderer/media/rtc_peer_connection_handler.h b/content/renderer/media/rtc_peer_connection_handler.h

index 8e8af25fcfd40e043f9f4dc7bbbe5dc4f4dde89a..a2e1b2046ff58a862d66207488773b76a07e0abd 100644

--- a/content/renderer/media/rtc_peer_connection_handler.h

+++ b/content/renderer/media/rtc_peer_connection_handler.h

@@ -225,8 +225,14 @@ class CONTENT_EXPORT RTCPeerConnectionHandler

base::ThreadChecker thread_checker_;

- // |client_| is a weak pointer, and is valid until stop() has returned.

+ // |client_| is a weak pointer to the blink object (blink::RTCPeerConnection)

+ // that owns this object.

+ // It is valid for the lifetime of this object.

blink::WebRTCPeerConnectionHandlerClient* client_;

+ // True if this PeerConnection has been closed.

+ // After PeerConnection has been closed, this object may no longer forward

tommi (sloooow) - chröme 2015/11/12 14:53:19 nit: After the PeerConnection has been ...

perkj_chrome 2015/11/12 15:48:38 Done.

+ // callbacks to blink.

+ bool is_closed_;

// |dependency_factory_| is a raw pointer, and is valid for the lifetime of

// RenderThreadImpl.

« no previous file with comments | « no previous file | content/renderer/media/rtc_peer_connection_handler.cc » ('j') | content/renderer/media/rtc_peer_connection_handler.cc » ('J')