Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1438143002: Oilpan: add missing LocalFrame::m_pluginElements annotation. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: add missing LocalFrame::m_pluginElements annotation. TBR=oilpan-reviews BUG=553613 NOTRY=true Committed: https://crrev.com/3e263b2c3d78cb49686201045b922f095bc91eda Cr-Commit-Position: refs/heads/master@{#359274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (1 generated)
sof
5 years, 1 month ago (2015-11-12 06:24:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438143002/1
5 years, 1 month ago (2015-11-12 06:24:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 06:28:56 UTC) #4
haraken
LGTM
5 years, 1 month ago (2015-11-12 06:32:33 UTC) #5
haraken
I'm wondering why the GC plugin hasn't detected this one.
5 years, 1 month ago (2015-11-12 07:23:58 UTC) #6
sof
On 2015/11/12 07:23:58, haraken wrote: > I'm wondering why the GC plugin hasn't detected this ...
5 years, 1 month ago (2015-11-12 07:36:25 UTC) #7
haraken
On 2015/11/12 07:36:25, sof wrote: > On 2015/11/12 07:23:58, haraken wrote: > > I'm wondering ...
5 years, 1 month ago (2015-11-12 07:44:01 UTC) #8
sof
On 2015/11/12 07:44:01, haraken wrote: > On 2015/11/12 07:36:25, sof wrote: > > On 2015/11/12 ...
5 years, 1 month ago (2015-11-12 07:48:34 UTC) #9
sof
On 2015/11/12 07:36:25, sof wrote: > On 2015/11/12 07:23:58, haraken wrote: > > I'm wondering ...
5 years, 1 month ago (2015-11-12 08:03:39 UTC) #10
haraken
On 2015/11/12 08:03:39, sof wrote: > On 2015/11/12 07:36:25, sof wrote: > > On 2015/11/12 ...
5 years, 1 month ago (2015-11-12 10:17:59 UTC) #11
sof
On 2015/11/12 10:17:59, haraken wrote: > On 2015/11/12 08:03:39, sof wrote: > > On 2015/11/12 ...
5 years, 1 month ago (2015-11-12 10:21:41 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:05:33 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e263b2c3d78cb49686201045b922f095bc91eda
Cr-Commit-Position: refs/heads/master@{#359274}

Powered by Google App Engine
This is Rietveld 408576698