Oilpan: add missing LocalFrame::m_pluginElements annotation.

Oilpan: add missing LocalFrame::m_pluginElements annotation.

TBR=oilpan-reviews
BUG=553613
NOTRY=true

Committed: https://crrev.com/3e263b2c3d78cb49686201045b922f095bc91eda
Cr-Commit-Position: refs/heads/master@{#359274}

[sof, 2015-11-12 06:24:45]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-12 06:24:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438143002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438143002/1

[commit-bot: I haz the power, 2015-11-12 06:28:56]

Committed patchset #1 (id:1)

[haraken, 2015-11-12 06:32:33]

LGTM

[haraken, 2015-11-12 07:23:58]

I'm wondering why the GC plugin hasn't detected this one.

[sof, 2015-11-12 07:36:25]

On 2015/11/12 07:23:58, haraken wrote:
> I'm wondering why the GC plugin hasn't detected this one.

Yes, I've only seen this one with warn-raw-ptr=1 elsewhere...that builder
wouldn't happen to be using blink_gc_plugin_flags="warn-raw-ptr=1" ?

[haraken, 2015-11-12 07:44:01]

On 2015/11/12 07:36:25, sof wrote:
> On 2015/11/12 07:23:58, haraken wrote:
> > I'm wondering why the GC plugin hasn't detected this one.
> 
> Yes, I've only seen this one with warn-raw-ptr=1 elsewhere...that builder
> wouldn't happen to be using blink_gc_plugin_flags="warn-raw-ptr=1" ?

I haven't observed this one in my local builds, where I'm just using
GYP_DEFINES='enable_oilpan=1 blink_gc_plugin=1'. Maybe it's worth making
warn-raw-ptr=1 when the gc plugin is enabled.

[sof, 2015-11-12 07:48:34]

On 2015/11/12 07:44:01, haraken wrote:
> On 2015/11/12 07:36:25, sof wrote:
> > On 2015/11/12 07:23:58, haraken wrote:
> > > I'm wondering why the GC plugin hasn't detected this one.
> > 
> > Yes, I've only seen this one with warn-raw-ptr=1 elsewhere...that builder
> > wouldn't happen to be using blink_gc_plugin_flags="warn-raw-ptr=1" ?
> 
> I haven't observed this one in my local builds, where I'm just using
> GYP_DEFINES='enable_oilpan=1 blink_gc_plugin=1'. Maybe it's worth making
> warn-raw-ptr=1 when the gc plugin is enabled.

It's been a firehose in the past, but maybe we're close to having addressed all
of these unsafe raw pointer issues by now.

[sof, 2015-11-12 08:03:39]

On 2015/11/12 07:36:25, sof wrote:
> On 2015/11/12 07:23:58, haraken wrote:
> > I'm wondering why the GC plugin hasn't detected this one.
> 
> Yes, I've only seen this one with warn-raw-ptr=1 elsewhere...that builder
> wouldn't happen to be using blink_gc_plugin_flags="warn-raw-ptr=1" ?

I don't think that is what's happening here, but the definition of
HTMLPluginElement being in scope when processing LocalFrame.h

However, enabling warn-raw-ptr=1 locally might be a way to pro-actively flush
out all these build breakers.

[haraken, 2015-11-12 10:17:59]

On 2015/11/12 08:03:39, sof wrote:
> On 2015/11/12 07:36:25, sof wrote:
> > On 2015/11/12 07:23:58, haraken wrote:
> > > I'm wondering why the GC plugin hasn't detected this one.
> > 
> > Yes, I've only seen this one with warn-raw-ptr=1 elsewhere...that builder
> > wouldn't happen to be using blink_gc_plugin_flags="warn-raw-ptr=1" ?
> 
> I don't think that is what's happening here, but the definition of
> HTMLPluginElement being in scope when processing LocalFrame.h
> 
> However, enabling warn-raw-ptr=1 locally might be a way to pro-actively flush
> out all these build breakers.

If there are a bunch of more places we should fix, would it be an option that we
ask animeer to disabled warn-raw-ptr=1 on the official build bot?

[sof, 2015-11-12 10:21:41]

On 2015/11/12 10:17:59, haraken wrote:
> On 2015/11/12 08:03:39, sof wrote:
> > On 2015/11/12 07:36:25, sof wrote:
> > > On 2015/11/12 07:23:58, haraken wrote:
> > > > I'm wondering why the GC plugin hasn't detected this one.
> > > 
> > > Yes, I've only seen this one with warn-raw-ptr=1 elsewhere...that builder
> > > wouldn't happen to be using blink_gc_plugin_flags="warn-raw-ptr=1" ?
> > 
> > I don't think that is what's happening here, but the definition of
> > HTMLPluginElement being in scope when processing LocalFrame.h
> > 
> > However, enabling warn-raw-ptr=1 locally might be a way to pro-actively
flush
> > out all these build breakers.
> 
> If there are a bunch of more places we should fix, would it be an option that
we
> ask animeer to disabled warn-raw-ptr=1 on the official build bot?

The situation is vaguely ridiculous & time wasteful, not having access to much
information about these builders, but I'm quite sure warn-raw-ptr=1 isn't being
used. Rather some form of PCH is what these builders are using for extra
optimizations in official releases. But that would also be a guess.

[commit-bot: I haz the power, 2015-11-12 20:05:33]

Patchset 1 (id:??) landed as
https://crrev.com/3e263b2c3d78cb49686201045b922f095bc91eda
Cr-Commit-Position: refs/heads/master@{#359274}