Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1438123008: Exclude src/android from CMake build too. (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Exclude src/android from CMake build too. It requires src/codec. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac10.9-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/0b47d4b520e8f0d4259cf5f263f502ccf9eaf0e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cmake/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438123008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438123008/1
5 years, 1 month ago (2015-11-13 15:17:26 UTC) #2
mtklein_C
5 years, 1 month ago (2015-11-13 15:17:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 15:30:44 UTC) #6
msarett
lgtm
5 years, 1 month ago (2015-11-13 15:37:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438123008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438123008/1
5 years, 1 month ago (2015-11-13 15:41:51 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 15:42:30 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0b47d4b520e8f0d4259cf5f263f502ccf9eaf0e7

Powered by Google App Engine
This is Rietveld 408576698