Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1438123007: [turbofan] Fix OSR entry in case label. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix OSR entry in case label. With do-expressions any expression used as a case label can turn into an OSR entry-point. This means the value being switched over is renamed to an OSR value and needs to be reloaded from the environment at each case. R=rossberg@chromium.org TEST=mjsunit/regress/regress-osr-in-case-label Committed: https://crrev.com/c42f188ce2dca1546f9578747f90438d0907b24c Cr-Commit-Position: refs/heads/master@{#31986}

Patch Set 1 #

Patch Set 2 : Skip for ignition. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +1 line, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-osr-in-case-label.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Starzinger
Who needs ClusterFuzz? :P
5 years, 1 month ago (2015-11-13 14:48:06 UTC) #1
rossberg
lgtm
5 years, 1 month ago (2015-11-13 14:50:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438123007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438123007/1
5 years, 1 month ago (2015-11-13 14:54:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/11705)
5 years, 1 month ago (2015-11-13 15:02:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438123007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438123007/20001
5 years, 1 month ago (2015-11-13 15:55:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-13 16:04:59 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-14 23:21:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c42f188ce2dca1546f9578747f90438d0907b24c
Cr-Commit-Position: refs/heads/master@{#31986}

Powered by Google App Engine
This is Rietveld 408576698