Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: mojo/devtools/common/devtoolslib/shell_arguments.py

Issue 1438123003: Fix `--verbose` handling in android_shell. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Address Ben's comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/devtools/common/devtoolslib/android_shell.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/shell_arguments.py
diff --git a/mojo/devtools/common/devtoolslib/shell_arguments.py b/mojo/devtools/common/devtoolslib/shell_arguments.py
index 024ee5107a628c39f8eeb82eef19124f2a4c4bf2..5ee28b2bd40d06b98b313ea9665b2c47e25c49ab 100644
--- a/mojo/devtools/common/devtoolslib/shell_arguments.py
+++ b/mojo/devtools/common/devtoolslib/shell_arguments.py
@@ -9,7 +9,6 @@ shell_config.ShellConfig.
"""
import os.path
-import sys
import urlparse
from devtoolslib.android_shell import AndroidShell
@@ -195,11 +194,9 @@ def get_shell(shell_config, shell_args):
ShellConfigurationException if shell abstraction could not be configured.
"""
if shell_config.android:
- verbose_pipe = sys.stdout if shell_config.verbose else None
-
shell = AndroidShell(shell_config.adb_path, shell_config.target_device,
logcat_tags=shell_config.logcat_tags,
- verbose_pipe=verbose_pipe)
+ verbose=shell_config.verbose)
device_status, error = shell.check_device(
require_root=shell_config.require_root)
« no previous file with comments | « mojo/devtools/common/devtoolslib/android_shell.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698