Fix `--verbose` handling in android_shell.

Fix `--verbose` handling in android_shell.

This suppresses stderr for the sub-commands that we don't want to print
to the terminal in addition to stdout. It turns out that, for instance,
`adb push` prints it's status to stderr for some reason.

R=qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/8717d112517cfaa3d2eb3ea5088b0a9cf0cebf97

[ppi, 2015-11-12 13:59:29]

Hi Ben, ptal.

[ppi, 2015-11-12 14:23:50]

Description was changed from

==========
Fix `--verbose` handling in android_shell.

This suppresses stderr for the sub-commands that we don't want to print
to the terminal in addition to stdout. It turns out that, for instance,
`adb push` prints it's status to stderr for some reason.
==========

to

==========
Fix `--verbose` handling in android_shell.

This suppresses stderr for the sub-commands that we don't want to print
to the terminal in addition to stdout. It turns out that, for instance,
`adb push` prints it's status to stderr for some reason.
==========

[ppi, 2015-11-12 14:25:10]

Changed as discussed in person, ptal.

[qsr, 2015-11-12 14:47:37]

LGTM with nit.

https://codereview.chromium.org/1438123003/diff/20001/mojo/devtools/common/de...
File mojo/devtools/common/devtoolslib/android_shell.py (right):

https://codereview.chromium.org/1438123003/diff/20001/mojo/devtools/common/de...
mojo/devtools/common/devtoolslib/android_shell.py:106: self.verbose_stderr =
sys.stderr if verbose else open(os.devnull, 'w')
sys.stderr if verbose else self.verbose_stdout
This will open one less file.

[ppi, 2015-11-12 14:50:17]

https://codereview.chromium.org/1438123003/diff/20001/mojo/devtools/common/de...
File mojo/devtools/common/devtoolslib/android_shell.py (right):

https://codereview.chromium.org/1438123003/diff/20001/mojo/devtools/common/de...
mojo/devtools/common/devtoolslib/android_shell.py:106: self.verbose_stderr =
sys.stderr if verbose else open(os.devnull, 'w')
On 2015/11/12 14:47:37, qsr wrote:
> sys.stderr if verbose else self.verbose_stdout
> This will open one less file.

Done.

[ppi, 2015-11-12 14:52:13]

Committed patchset #3 (id:40001) manually as
8717d112517cfaa3d2eb3ea5088b0a9cf0cebf97 (presubmit successful).