Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Unified Diff: components/variations/android/variations_seed_bridge.cc

Issue 1438123002: Removed callbacks to JNI functions + added gzip compressed seed support & pulling response time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implemented the rest TODOs: pulling time from response and GZIP compressed seed support Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/variations/android/variations_seed_bridge.cc
diff --git a/components/variations/android/variations_seed_bridge.cc b/components/variations/android/variations_seed_bridge.cc
index cf5cbe41db3ac65ff1fe91a503f42eb94c976575..5885668f0ea9f6ad149cba821fac99bc51503586 100644
--- a/components/variations/android/variations_seed_bridge.cc
+++ b/components/variations/android/variations_seed_bridge.cc
@@ -39,7 +39,9 @@ bool RegisterVariationsSeedBridge(JNIEnv* env) {
void GetVariationsFirstRunSeed(std::string* seed_data,
std::string* seed_signature,
- std::string* seed_country) {
+ std::string* seed_country,
+ base::Time* response_time,
+ bool* is_gzip_compressed) {
JNIEnv* env = AttachCurrentThread();
ScopedJavaLocalRef<jbyteArray> j_seed_data =
Java_VariationsSeedBridge_getVariationsFirstRunSeedData(
@@ -50,9 +52,18 @@ void GetVariationsFirstRunSeed(std::string* seed_data,
ScopedJavaLocalRef<jstring> j_seed_country =
Java_VariationsSeedBridge_getVariationsFirstRunSeedCountry(
env, GetApplicationContext());
+ ScopedJavaLocalRef<jstring> j_response_time =
+ Java_VariationsSeedBridge_getVariationsFirstRunSeedDate(
+ env, GetApplicationContext());
+ jboolean j_is_gzip_compressed =
+ Java_VariationsSeedBridge_getVariationsFirstRunSeedIsGzipCompressed(
+ env, GetApplicationContext());
+ base::Time::FromString(ConvertJavaStringToUTF8(env, j_response_time).c_str(),
Alexei Svitkine (slow) 2015/11/12 16:26:55 I think this logic should be in the variations cod
Alexander Agulenko 2015/11/12 20:07:42 Acknowledged (still working on it).
Alexander Agulenko 2015/11/12 20:15:40 Done.
+ response_time);
*seed_data = JavaByteArrayToString(env, j_seed_data.obj());
*seed_signature = ConvertJavaStringToUTF8(j_seed_signature);
*seed_country = ConvertJavaStringToUTF8(j_seed_country);
+ *is_gzip_compressed = static_cast<bool>(j_is_gzip_compressed);
}
} // namespace android

Powered by Google App Engine
This is Rietveld 408576698