Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: chrome/browser/metrics/variations/chrome_variations_service_client.h

Issue 1438123002: Removed callbacks to JNI functions + added gzip compressed seed support & pulling response time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Implemented the rest TODOs: pulling time from response and GZIP compressed seed support Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_VARIATIONS_CHROME_VARIATIONS_SERVICE_CLIENT_H_ 5 #ifndef CHROME_BROWSER_METRICS_VARIATIONS_CHROME_VARIATIONS_SERVICE_CLIENT_H_
6 #define CHROME_BROWSER_METRICS_VARIATIONS_CHROME_VARIATIONS_SERVICE_CLIENT_H_ 6 #define CHROME_BROWSER_METRICS_VARIATIONS_CHROME_VARIATIONS_SERVICE_CLIENT_H_
7 7
8 #include <string>
Alexei Svitkine (slow) 2015/11/12 16:26:55 Keep this. It's still used on line 28 and elsewher
Alexander Agulenko 2015/11/12 20:06:41 I've just removed the include that I have added to
9
10 #include "base/basictypes.h" 8 #include "base/basictypes.h"
11 #include "base/bind.h"
12 #include "components/variations/service/variations_service_client.h" 9 #include "components/variations/service/variations_service_client.h"
13 #include "components/variations/variations_seed_store.h"
14 10
15 #if defined(OS_WIN) 11 #if defined(OS_WIN)
16 #include "chrome/browser/metrics/variations/variations_registry_syncer_win.h" 12 #include "chrome/browser/metrics/variations/variations_registry_syncer_win.h"
17 #endif 13 #endif
18 14
19 // ChromeVariationsServiceClient provides an implementation of 15 // ChromeVariationsServiceClient provides an implementation of
20 // VariationsServiceClient that depends on chrome/. 16 // VariationsServiceClient that depends on chrome/.
21 class ChromeVariationsServiceClient 17 class ChromeVariationsServiceClient
22 : public variations::VariationsServiceClient { 18 : public variations::VariationsServiceClient {
23 public: 19 public:
24 ChromeVariationsServiceClient(); 20 ChromeVariationsServiceClient();
25 ~ChromeVariationsServiceClient() override; 21 ~ChromeVariationsServiceClient() override;
26 22
27 // variations::VariationsServiceClient: 23 // variations::VariationsServiceClient:
28 std::string GetApplicationLocale() override; 24 std::string GetApplicationLocale() override;
29 base::SequencedWorkerPool* GetBlockingPool() override; 25 base::SequencedWorkerPool* GetBlockingPool() override;
30 base::Callback<base::Version(void)> GetVersionForSimulationCallback() 26 base::Callback<base::Version(void)> GetVersionForSimulationCallback()
31 override; 27 override;
32 net::URLRequestContextGetter* GetURLRequestContext() override; 28 net::URLRequestContextGetter* GetURLRequestContext() override;
33 network_time::NetworkTimeTracker* GetNetworkTimeTracker() override; 29 network_time::NetworkTimeTracker* GetNetworkTimeTracker() override;
34 version_info::Channel GetChannel() override; 30 version_info::Channel GetChannel() override;
35 bool OverridesRestrictParameter(std::string* parameter) override; 31 bool OverridesRestrictParameter(std::string* parameter) override;
36 void OnInitialStartup() override; 32 void OnInitialStartup() override;
37 variations::VariationsFirstRunSeedCallback GetVariationsFirstRunSeedCallback()
38 override;
39 33
40 private: 34 private:
41 #if defined(OS_WIN) 35 #if defined(OS_WIN)
42 // Starts syncing Google Update Variation IDs with the registry. 36 // Starts syncing Google Update Variation IDs with the registry.
43 void StartGoogleUpdateRegistrySync(); 37 void StartGoogleUpdateRegistrySync();
44 38
45 // Helper that handles synchronizing Variations with the Registry. 39 // Helper that handles synchronizing Variations with the Registry.
46 chrome_variations::VariationsRegistrySyncer registry_syncer_; 40 chrome_variations::VariationsRegistrySyncer registry_syncer_;
47 #endif 41 #endif
48 42
49 DISALLOW_COPY_AND_ASSIGN(ChromeVariationsServiceClient); 43 DISALLOW_COPY_AND_ASSIGN(ChromeVariationsServiceClient);
50 }; 44 };
51 45
52 #endif // CHROME_BROWSER_METRICS_VARIATIONS_CHROME_VARIATIONS_SERVICE_CLIENT_H_ 46 #endif // CHROME_BROWSER_METRICS_VARIATIONS_CHROME_VARIATIONS_SERVICE_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698