Factor CSS3 matching rules.

Factor CSS3 matching rules.

This factors out the CSS3 matching rules, creates tests for it,
and uses it with the GDI font manager.

BUG=chromium:554238, skia:4037
TBR=reed@google.com
No public API changes.

Committed: https://skia.googlesource.com/skia/+/147ea2fb7ad9adeeb52fe5549f7ba20953296f6f

[bungeman-skia, 2015-11-11 23:41:03]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 23:41:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438113002/20001

[commit-bot: I haz the power, 2015-11-11 23:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 23:42:34]

Dry run: Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)

[bungeman-skia, 2015-11-11 23:42:37]

bungeman@google.com changed reviewers:
+ mtklein@google.com

[bungeman-skia, 2015-11-11 23:42:38]

Now that someone wants to use this, make the implementation available, test it,
and use it.

[bungeman-skia, 2015-11-11 23:43:34]

On 2015/11/11 23:42:38, bungeman1 wrote:
> Now that someone wants to use this, make the implementation available, test
it,
> and use it.

Did I mention I don't like this 10.8 bot?

[mtklein, 2015-11-12 14:22:14]

Description was changed from

==========
Factor CSS3 matching rules.

This factors out the CSS3 matching rules, creates tests for it,
and uses it with the GDI font manager.

BUG=chromium:554238
==========

to

==========
Factor CSS3 matching rules.

This factors out the CSS3 matching rules, creates tests for it,
and uses it with the GDI font manager.

BUG=chromium:554238,skia:4037
==========

[bungeman-skia, 2015-11-12 15:22:08]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 15:22:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438113002/40001

[commit-bot: I haz the power, 2015-11-12 15:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 15:24:13]

Dry run: Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-...)

[mtklein, 2015-11-12 15:27:29]

https://codereview.chromium.org/1438113002/diff/40001/gyp/tests.gypi
File gyp/tests.gypi (right):

https://codereview.chromium.org/1438113002/diff/40001/gyp/tests.gypi#newcode52
gyp/tests.gypi:52: 'xcode_settings': {
Let's do this globally?

[mtklein, 2015-11-12 15:28:45]

https://codereview.chromium.org/1438113002/diff/40001/gyp/tests.gypi
File gyp/tests.gypi (right):

https://codereview.chromium.org/1438113002/diff/40001/gyp/tests.gypi#newcode52
gyp/tests.gypi:52: 'xcode_settings': {
On 2015/11/12 at 15:27:29, mtklein wrote:
> Let's do this globally?

(I think that'll fix your 10.8 bot.)

[bungeman-skia, 2015-11-12 15:36:53]

On 2015/11/12 15:28:45, mtklein wrote:
> https://codereview.chromium.org/1438113002/diff/40001/gyp/tests.gypi
> File gyp/tests.gypi (right):
> 
> https://codereview.chromium.org/1438113002/diff/40001/gyp/tests.gypi#newcode52
> gyp/tests.gypi:52: 'xcode_settings': {
> On 2015/11/12 at 15:27:29, mtklein wrote:
> > Let's do this globally?
> 
> (I think that'll fix your 10.8 bot.)

Yeah, it has to done globally, at least the libc++ part (which requires 10.7
anyway) in order to avoid mixing libstdc++ and libc++. I could make changes and
avoid this until we can actually fully drop support for 10.6.

[bungeman-skia, 2015-11-12 17:00:34]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 17:00:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438113002/60001

[commit-bot: I haz the power, 2015-11-12 17:11:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 17:11:44]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-11-12 17:29:50]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2015-11-12 17:30:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438113002/60001

[commit-bot: I haz the power, 2015-11-12 17:30:05]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-11-12 23:30 UTC

[commit-bot: I haz the power, 2015-11-12 17:31:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 17:31:21]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2015-11-12 17:49:20]

Description was changed from

==========
Factor CSS3 matching rules.

This factors out the CSS3 matching rules, creates tests for it,
and uses it with the GDI font manager.

BUG=chromium:554238,skia:4037
==========

to

==========
Factor CSS3 matching rules.

This factors out the CSS3 matching rules, creates tests for it,
and uses it with the GDI font manager.

BUG=chromium:554238,skia:4037

TBR=reed@google.com
No public API changes.
==========

[mtklein, 2015-11-12 17:49:21]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-11-12 17:49:22]

lgtm

[commit-bot: I haz the power, 2015-11-12 17:49:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438113002/60001

[commit-bot: I haz the power, 2015-11-12 17:50:11]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/147ea2fb7ad9adeeb52fe5549f7ba20953296f6f