Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: runtime/bin/dbg_connection.cc

Issue 14381005: Implement list isolates command (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/dbg_message.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dbg_connection.cc
===================================================================
--- runtime/bin/dbg_connection.cc (revision 21764)
+++ runtime/bin/dbg_connection.cc (working copy)
@@ -180,7 +180,7 @@
void DebuggerConnectionHandler::HandleMessages() {
static JSONDebuggerCommand generic_debugger_commands[] = {
{ "interrupt", HandleInterruptCmd },
- { "isolates", HandleIsolatesListCmd },
+ { "getIsolateIds", HandleIsolatesListCmd },
{ NULL, NULL }
};
@@ -404,7 +404,11 @@
MessageParser msg_parser(in_msg->buffer(), in_msg->buffer_len());
int msg_id = msg_parser.MessageId();
ASSERT(msg_id >= 0);
- in_msg->SendErrorReply(msg_id, "isolate list command unimplemented");
+ dart::TextBuffer msg(64);
+ msg.Printf("{ \"id\": %d, \"result\": { \"isolateIds\": [", msg_id);
+ DbgMsgQueueList::ListIsolateIds(&msg);
+ msg.Printf("]}}");
+ in_msg->SendReply(&msg);
}
« no previous file with comments | « no previous file | runtime/bin/dbg_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698