Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: chrome/browser/extensions/webstore_startup_installer_browsertest.cc

Issue 14381004: Two fixes for the limited install from webstore flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/startup_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_startup_installer_browsertest.cc
diff --git a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc
index 60635363b8640f30aa27c7398152a9e29e449346..76b4ff17fb64d5d56cf8c579b5b8f171d1ad3cf8 100644
--- a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc
+++ b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc
@@ -354,8 +354,6 @@ IN_PROC_BROWSER_TEST_F(CommandLineWebstoreInstall, LimitedAccept) {
CommandLine* command_line = CommandLine::ForCurrentProcess();
command_line->AppendSwitchASCII(
switches::kLimitedInstallFromWebstore, "2");
- command_line->AppendSwitchASCII(
- switches::kAppsGalleryInstallAutoConfirmForTests, "accept");
helper.LimitedInstallFromWebstore(*command_line, browser()->profile(),
MessageLoop::QuitWhenIdleClosure());
MessageLoop::current()->Run();
@@ -363,17 +361,3 @@ IN_PROC_BROWSER_TEST_F(CommandLineWebstoreInstall, LimitedAccept) {
EXPECT_TRUE(saw_install());
EXPECT_EQ(0, browser_open_count());
}
-
-IN_PROC_BROWSER_TEST_F(CommandLineWebstoreInstall, LimitedCancel) {
James Hawkins 2013/04/19 23:53:23 Is there any test that needs to be added?
- CommandLine* command_line = CommandLine::ForCurrentProcess();
- command_line->AppendSwitchASCII(
- switches::kLimitedInstallFromWebstore, "2");
- command_line->AppendSwitchASCII(
- switches::kAppsGalleryInstallAutoConfirmForTests, "cancel");
- extensions::StartupHelper helper;
- helper.LimitedInstallFromWebstore(*command_line, browser()->profile(),
- MessageLoop::QuitWhenIdleClosure());
- MessageLoop::current()->Run();
- EXPECT_FALSE(saw_install());
- EXPECT_EQ(0, browser_open_count());
-}
« no previous file with comments | « chrome/browser/extensions/startup_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698