Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPainter.cpp

Issue 1438043012: Avoid int coercion of box-shadow args (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BoxPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/BoxPainter.cpp b/third_party/WebKit/Source/core/paint/BoxPainter.cpp
index a4e829f2a8703a4084df1fc5648e4860cc61a7e7..3b1f0b38ee6dabdfe748554c65791d4706b57fe1 100644
--- a/third_party/WebKit/Source/core/paint/BoxPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/BoxPainter.cpp
@@ -671,7 +671,6 @@ void BoxPainter::paintBoxShadow(const PaintInfo& info, const LayoutRect& paintRe
else
influenceRect.shrinkRadii(-changeAmount);
- // TODO: support non-integer shadows - crbug.com/334829
FloatRoundedRect roundedFillRect = border;
roundedFillRect.inflate(shadowSpread);
@@ -701,8 +700,7 @@ void BoxPainter::paintBoxShadow(const PaintInfo& info, const LayoutRect& paintRe
else
clippedEdges |= GraphicsContext::BottomEdge;
}
- // TODO: support non-integer shadows - crbug.com/334828
- context->drawInnerShadow(border, shadowColor, flooredIntSize(shadowOffset), shadowBlur, shadowSpread, clippedEdges);
chrishtr 2015/11/16 17:12:44 Please also update the call site in ThemePainterMa
f(malita) 2015/11/17 13:55:23 Done.
+ context->drawInnerShadow(border, shadowColor, shadowOffset, shadowBlur, shadowSpread, clippedEdges);
}
}
}

Powered by Google App Engine
This is Rietveld 408576698