Move ScrollAnimatorTest.cpp to Source/platform/scroll/.

Move ScrollAnimatorTest.cpp to Source/platform/scroll/.

Some classes in these files were moved into anonymous namespaces, because
otherwise they generated ODR violations by being linked into the same test
binary. (And this manifested as a crash, rather than a compile failure!)

BUG=353585
Committed: https://crrev.com/0a6e1d78456bfaf594c236123081e5f3d457ed9c
Cr-Commit-Position: refs/heads/master@{#359850}

[jbroman, 2015-11-13 23:57:31]

jbroman@chromium.org changed reviewers:
+ mkwst@chromium.org, skobes@chromium.org

[jbroman, 2015-11-13 23:57:32]

This test should be next to the file it tests, in Source/platform/scroll/. I had
to fix a couple minor issues to make it work, but it does work.

[skobes, 2015-11-14 00:10:32]

lgtm

https://codereview.chromium.org/1438043011/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/testing/RunAllTests.cpp (right):

https://codereview.chromium.org/1438043011/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/RunAllTests.cpp:56:
WTF::initialize(CurrentTime, CurrentTime, CurrentTime, nullptr, nullptr);
Hmm, this kind of violates the contract of monotonicallyIncreasingTimeFunction. 
On the other hand, it can probably go back to nullptr when
http://crrev.com/1444663002 lands.

[jbroman, 2015-11-14 00:14:58]

https://codereview.chromium.org/1438043011/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/testing/RunAllTests.cpp (right):

https://codereview.chromium.org/1438043011/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/RunAllTests.cpp:56:
WTF::initialize(CurrentTime, CurrentTime, CurrentTime, nullptr, nullptr);
On 2015/11/14 at 00:10:32, skobes wrote:
> Hmm, this kind of violates the contract of
monotonicallyIncreasingTimeFunction.  On the other hand, it can probably go back
to nullptr when http://crrev.com/1444663002 lands.

Does it any more so than for the other time functions? A constant zero is
monotonically increasing (i.e. it never decreases), and should only have the
effect of making things seem to happen instantaneously.

[skobes, 2015-11-14 00:19:44]

On 2015/11/14 00:14:58, jbroman wrote:
> Does it any more so than for the other time functions? A constant zero is
> monotonically increasing (i.e. it never decreases), and should only have the
> effect of making things seem to happen instantaneously.

Oh you're right.  I thought it meant "strictly increasing" (versus
non-decreasing), but I was misremembering college calculus. :)

[Mike West, 2015-11-16 10:40:11]

I don't think you need my LGTM, but LGTM just in case. :)

[jbroman, 2015-11-16 15:20:34]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2015-11-16 15:21:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1438043011/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1438043011/20001

[commit-bot: I haz the power, 2015-11-16 16:20:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-16 16:21:29]

Patchset 2 (id:??) landed as
https://crrev.com/0a6e1d78456bfaf594c236123081e5f3d457ed9c
Cr-Commit-Position: refs/heads/master@{#359850}

[jbroman, 2015-11-16 17:47:03]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1450953002/ by jbroman@chromium.org.

The reason for reverting is: Fails on Oilpan (leaked mock object). Suspect an
explicit GC is required.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan....

[skobes, 2015-11-16 18:28:13]

On 2015/11/16 17:47:03, jbroman wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/1450953002/ by mailto:jbroman@chromium.org.
> 
> The reason for reverting is: Fails on Oilpan (leaked mock object). Suspect an
> explicit GC is required.

FYI it might be easier to wait for http://crrev.com/1444663002 before relanding.
 I verified that it passes with Oilpan enabled.

[jbroman, 2015-11-16 18:38:18]

On 2015/11/16 at 18:28:13, skobes wrote:
> On 2015/11/16 17:47:03, jbroman wrote:
> > A revert of this CL (patchset #2 id:20001) has been created in
> > https://codereview.chromium.org/1450953002/ by mailto:jbroman@chromium.org.
> > 
> > The reason for reverting is: Fails on Oilpan (leaked mock object). Suspect
an
> > explicit GC is required.
> 
> FYI it might be easier to wait for http://crrev.com/1444663002 before
relanding.  I verified that it passes with Oilpan enabled.

I think that's orthogonal. The reason this was reverted is that
blink_platform_unittests doesn't clean up the Oilpan heap.