components/ntp_suggestions/OWNERS - Issue 1438043008: Creating the NTP snippet service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_suggestions/OWNERS

Issue 1438043008: Creating the NTP snippet service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/ntp_suggestions/DEPS ('K') | « components/ntp_suggestions/DEPS ('k') | components/ntp_suggestions/ntp_suggestions_service.h » ('j') | components/ntp_suggestions/ntp_suggestions_service.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 noyau@chromium.org

	2 maybelle@chromium.org
	jochen (gone - plz use gerrit) 2015/11/17 13:45:27 only chromium committers can be in owners files only chromium committers can be in owners files noyau (Ping after 24h) 2015/11/17 17:00:34 Good catch. How do you check that someone is a chr Show quoted text On 2015/11/17 13:45:27, jochen wrote: > only chromium committers can be in owners files Good catch. How do you check that someone is a chromium committer? Checking in groups is quite cumbersome, is there another tool I'm not aware of? Bernhard Bauer 2015/11/17 17:10:44 Could you add me in lieu? Show quoted text On 2015/11/17 13:45:27, jochen wrote: > only chromium committers can be in owners files Could you add me in lieu? noyau (Ping after 24h) 2015/11/18 10:42:03 Done. Show quoted text On 2015/11/17 17:10:44, Bernhard Bauer wrote: > On 2015/11/17 13:45:27, jochen wrote: > > only chromium committers can be in owners files > > Could you add me in lieu? Done. jochen (gone - plz use gerrit) 2015/11/18 16:22:48 check https://chromium-committers.appspot.com/list Show quoted text On 2015/11/17 at 17:00:34, noyau wrote: > On 2015/11/17 13:45:27, jochen wrote: > > only chromium committers can be in owners files > > Good catch. How do you check that someone is a chromium committer? Checking in groups is quite cumbersome, is there another tool I'm not aware of? check https://chromium-committers.appspot.com/lists/committers@chromium.org Bernhard Bauer 2015/11/18 16:42:47 (If you get a 404, go to the root page first and s Show quoted text On 2015/11/18 16:22:48, jochen wrote: > On 2015/11/17 at 17:00:34, noyau wrote: > > On 2015/11/17 13:45:27, jochen wrote: > > > only chromium committers can be in owners files > > > > Good catch. How do you check that someone is a chromium committer? Checking in > groups is quite cumbersome, is there another tool I'm not aware of? > > check https://chromium-committers.appspot.com/lists/committers@chromium.org (If you get a 404, go to the root page first and sign in with your @chromium.org account.)
OLD	NEW