components/ntp_suggestions/DEPS - Issue 1438043008: Creating the NTP snippet service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/ntp_suggestions/DEPS

Issue 1438043008: Creating the NTP snippet service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/keyed_service",	2 "+components/keyed_service",
	jochen (gone - plz use gerrit) 2015/11/17 13:45:27 maybe restrict to .../core ? maybe restrict to .../core ? sdefresne 2015/11/17 13:57:29 This should be "+components/keyed_service/core" as This should be "+components/keyed_service/core" as components/keyed_service/{content,ios} should only be used from the embedder. noyau (Ping after 24h) 2015/11/17 17:00:33 Done. Show quoted text On 2015/11/17 13:45:27, jochen wrote: > maybe restrict to .../core ? Done. noyau (Ping after 24h) 2015/11/17 17:00:33 Done. Show quoted text On 2015/11/17 13:57:29, sdefresne wrote: > This should be "+components/keyed_service/core" as > components/keyed_service/{content,ios} should only be used from the embedder. Done.
3 "+components/drive",

4 ]	3 ]

5

OLD	NEW