Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 1438043006: Check in Data Saver extension into Chromium (Closed)

Created:
5 years, 1 month ago by bustamante1
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, bengr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check in Data Saver extension into Chromium This is pulled directly from the pbulicly accessible version on the Chrome Web Store. BUG=555142 Committed: https://crrev.com/9451d8fd5d671585ebc1e2fa7ade337d8cdbc667 Cr-Commit-Position: refs/heads/master@{#359785}

Patch Set 1 #

Patch Set 2 : Update README file #

Patch Set 3 : Add information for presubmit #

Patch Set 4 : Fix presubmit issues #

Patch Set 5 : Make all lines<80 characters, fixed remaining presubmit warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8815 lines, -0 lines) Patch
A chrome/test/data/chromeproxy/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/README View 1 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/am/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ar/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/bg/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/bn/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ca/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/cs/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/da/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/de/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/el/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/en/messages.json View 1 chunk +192 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/en_GB/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/es/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/es_419/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/et/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/fa/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/fi/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/fil/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/fr/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/gu/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/he/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/hi/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/hr/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/hu/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/id/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/it/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ja/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/kn/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ko/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/lt/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/lv/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ml/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/mr/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ms/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/nb/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/nl/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/pl/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/pt/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/pt_BR/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/pt_PT/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ro/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ru/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/sk/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/sl/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/sr/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/sr_Latn/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/sv/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/sw/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/ta/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/te/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/th/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/tr/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/uk/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/vi/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/zh/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/zh_CN/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_locales/zh_TW/messages.json View 1 chunk +113 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_metadata/computed_hashes.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/_metadata/verified_contents.json View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/background_compiled.js View 1 2 3 4 1 chunk +43 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/images/alert.webp View Binary file 0 comments Download
A chrome/test/data/chromeproxy/extension/images/app_icon128.png View Binary file 0 comments Download
A chrome/test/data/chromeproxy/extension/images/proxy-disabled19.png View Binary file 0 comments Download
A chrome/test/data/chromeproxy/extension/images/proxy-disabled38.png View Binary file 0 comments Download
A chrome/test/data/chromeproxy/extension/images/proxy-enabled19.webp View Binary file 0 comments Download
A chrome/test/data/chromeproxy/extension/images/proxy-enabled38.webp View Binary file 0 comments Download
A chrome/test/data/chromeproxy/extension/manifest.json View 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/popup.css View 1 2 3 1 chunk +121 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/popup.html View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/test/data/chromeproxy/extension/popup_compiled.js View 1 2 3 4 1 chunk +2160 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (15 generated)
bustamante
PTAL when you get a chance
5 years, 1 month ago (2015-11-13 00:04:33 UTC) #4
Not at Google. Contact bengr
lgtm
5 years, 1 month ago (2015-11-13 18:28:58 UTC) #5
Not at Google. Contact bengr
Should the directory be called "data_saver" or something like that?
5 years, 1 month ago (2015-11-13 18:29:45 UTC) #6
bustamante
On 2015/11/13 18:29:45, kundaji wrote: > Should the directory be called "data_saver" or something like ...
5 years, 1 month ago (2015-11-13 18:34:37 UTC) #7
Not at Google. Contact bengr
SGTM
5 years, 1 month ago (2015-11-13 18:35:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438043006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438043006/20001
5 years, 1 month ago (2015-11-13 18:37:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 1 month ago (2015-11-13 19:06:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438043006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438043006/40001
5 years, 1 month ago (2015-11-13 19:49:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 1 month ago (2015-11-13 20:03:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438043006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438043006/60001
5 years, 1 month ago (2015-11-13 21:11:56 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 1 month ago (2015-11-13 21:26:06 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438043006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438043006/80001
5 years, 1 month ago (2015-11-14 00:59:41 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/96123)
5 years, 1 month ago (2015-11-14 04:13:39 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438043006/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438043006/80001
5 years, 1 month ago (2015-11-15 20:59:11 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 1 month ago (2015-11-15 22:33:36 UTC) #30
commit-bot: I haz the power
5 years, 1 month ago (2015-11-15 22:34:22 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9451d8fd5d671585ebc1e2fa7ade337d8cdbc667
Cr-Commit-Position: refs/heads/master@{#359785}

Powered by Google App Engine
This is Rietveld 408576698