Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1438043005: Closure compiler: Add app_remoting_webapp to bot. Fix some errors. (Closed)

Created:
5 years, 1 month ago by tommycli
Modified:
5 years, 1 month ago
Reviewers:
Dan Beam, kelvinp
CC:
chromium-reviews, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, jlklein+watch-closure_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Closure compiler: Add app_remoting_webapp to bot. Fix some errors. This patch: 1) Adds app_remoting_webapp to the closure compile bot. 2) Fixes some of the app_remoting_webapp compile errors. BUG=NONE Committed: https://crrev.com/208aabb5acb620d7f812320cd70780ae39fd435d Cr-Commit-Position: refs/heads/master@{#359470}

Patch Set 1 #

Patch Set 2 : Fix parameter notation on createWindow function. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M remoting/app_remoting_webapp_files.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/webapp/app_remoting/js/app_connected_view.js View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/webapp/app_remoting/js/ar_background.js View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/files.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/closure_compiler/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438043005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438043005/1
5 years, 1 month ago (2015-11-12 18:41:38 UTC) #2
kelvinp
lgtm
5 years, 1 month ago (2015-11-12 18:48:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-12 19:38:21 UTC) #6
Dan Beam
lgtm++
5 years, 1 month ago (2015-11-12 22:43:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438043005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438043005/20001
5 years, 1 month ago (2015-11-13 00:14:05 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-13 02:07:21 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 02:09:01 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/208aabb5acb620d7f812320cd70780ae39fd435d
Cr-Commit-Position: refs/heads/master@{#359470}

Powered by Google App Engine
This is Rietveld 408576698