Issue 143803020: Minor Refator: Change signature of focusedElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 143803020: Minor Refator: Change signature of focusedElement (Closed)

Created:
6 years, 10 months ago by spartha

Modified:
6 years, 10 months ago

Reviewers:
eseidel, Inactive, ojan

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Minor Refactor: Change signature of focusedElement focusedElement should be a const function. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167219

Patch Set 2 : Commit message updated #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/web/WebViewImpl.h	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	Source/web/WebViewImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Inactive

https://codereview.chromium.org/143803020/diff/30001/Source/web/WebViewImpl.h File Source/web/WebViewImpl.h (right): https://codereview.chromium.org/143803020/diff/30001/Source/web/WebViewImpl.h#newcode327 Source/web/WebViewImpl.h:327: WebCore::Element* focusedElement() const; I think several getters were non-const ...

6 years, 10 months ago (2014-02-13 16:10:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/143803020/30001

6 years, 10 months ago (2014-02-14 18:47:49 UTC) #4

Message was sent while issue was closed.

Change committed as 167219

Expand Messages | Collapse Messages

Issue 143803020: Minor Refator: Change signature of focusedElement (Closed)

Description

Patch Set 1 #

Patch Set 2 : Commit message updated #

Messages