Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143803017: FindBugs: Rename org.chromium.base.test.util.ScalableTimeout.ScaleTimeout to scaleTimeout. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org, Ilya Sherman, frankf+watch_chromium.org, tim+watch_chromium.org, craigdh+watch_chromium.org, benquan, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, haitaol+watch_chromium.org, jochen+watch_chromium.org, bulach+watch_chromium.org, ilevy-cc_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, klundberg+watch_chromium.org, rsimha+watch_chromium.org
Visibility:
Public.

Description

FindBugs: Rename org.chromium.base.test.util.ScalableTimeout.ScaleTimeout to scaleTimeout. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -53 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/ArchiveTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientOnFormResubmissionTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/FullScreenVideoTestAwContentsClient.java View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/util/JSUtils.java View 2 chunks +2 lines, -2 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/util/ScalableTimeout.java View 1 chunk +1 line, -1 line 0 comments Download
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/testshell/javatests/src/org/chromium/chrome/testshell/ChromiumTestShellTestBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationData.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewGestureHandlerTest.java View 4 chunks +5 lines, -5 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/GestureDetectorResetTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/SelectPopupTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CallbackHelper.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/CriteriaHelper.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/HistoryUtils.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/JavaScriptUtils.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/UiUtils.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell_apk/ContentShellTestBase.java View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Lei Zhang
Note: I'm just doing what FindBugs tells me to do. Not a Java style expert.
6 years, 10 months ago (2014-01-31 20:13:47 UTC) #1
nyquist
lgtm. Thanks for doing this!
6 years, 10 months ago (2014-02-04 04:47:01 UTC) #2
Lei Zhang
yfriedman: Can you OWNER review base and content? I'll likely TBR the remaining owners.
6 years, 10 months ago (2014-02-05 02:37:05 UTC) #3
Yaron
lgtm
6 years, 10 months ago (2014-02-05 03:15:30 UTC) #4
Lei Zhang
boliu: TBR for android_webview/
6 years, 10 months ago (2014-02-05 03:21:53 UTC) #5
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-05 03:21:58 UTC) #6
boliu
lgtm
6 years, 10 months ago (2014-02-05 03:39:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/143803017/1
6 years, 10 months ago (2014-02-05 03:50:13 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 04:53:57 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=48170
6 years, 10 months ago (2014-02-05 04:53:58 UTC) #10
Lei Zhang
On 2014/02/05 04:53:58, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 10 months ago (2014-02-05 08:00:24 UTC) #11
boliu
I think those are some remaining style errors when aurimas turned lint on. All of ...
6 years, 10 months ago (2014-02-05 16:25:07 UTC) #12
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 10 months ago (2014-02-06 00:06:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/143803017/1
6 years, 10 months ago (2014-02-06 00:08:14 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-06 00:35:18 UTC) #15
Message was sent while issue was closed. 
Change committed as 249177

Powered by Google App Engine
This is Rietveld 408576698