android_webview/native/aw_settings.h - Issue 143803016: [Android WebView] Fix thread unsafety in accessing Java side getters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/aw_settings.h

Issue 143803016: [Android WebView] Fix thread unsafety in accessing Java side getters (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added assert for the lock into the new getter (re-upload) Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/native/aw_settings.h

diff --git a/android_webview/native/aw_settings.h b/android_webview/native/aw_settings.h

index 7075c160a758654fce991ae7fe181e52d32fe12f..632862eb3768ccf2c1ab639e80a72e04c107b431 100644

--- a/android_webview/native/aw_settings.h

+++ b/android_webview/native/aw_settings.h

@@ -28,6 +28,7 @@ class AwSettings : public content::WebContentsObserver {

// Called from Java. Methods with "Locked" suffix require that the settings

// access lock is held during their execution.

void Destroy(JNIEnv* env, jobject obj);

+ void PopulateWebPreferencesLocked(JNIEnv* env, jobject obj, jlong web_prefs);

void ResetScrollAndScaleState(JNIEnv* env, jobject obj);

void UpdateEverythingLocked(JNIEnv* env, jobject obj);

void UpdateInitialPageScaleLocked(JNIEnv* env, jobject obj);