Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 143803004: android: Migrate old content readback to use async readback (and delegated renderer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed aelias@ comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index c5aa524ded2fa814c7b1989514d06cae4746f565..fe7db5a67c2f1b20d203d8f69dcefae4ba8c0278 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -225,7 +225,10 @@ class RenderWidgetHostViewAndroid
void WasResized();
- blink::WebGLId GetScaledContentTexture(float scale, gfx::Size* out_size);
+ void GetScaledContentBitmap(
+ float scale,
+ gfx::Size* out_size,
+ const base::Callback<void(bool, const SkBitmap&)>& result_callback);
bool PopulateBitmapWithContents(jobject jbitmap);
bool HasValidFrame() const;
@@ -296,11 +299,7 @@ class RenderWidgetHostViewAndroid
// Used to track whether this render widget needs a BeginFrame.
bool needs_begin_frame_;
- // Whether or not this widget is potentially attached to the view hierarchy.
- // This view may not actually be attached if this is true, but it should be
- // treated as such, because as soon as a ContentViewCore is set the layer
- // will be attached automatically.
- bool are_layers_attached_;
+ bool is_showing_;
// ContentViewCoreImpl is our interface to the view system.
ContentViewCoreImpl* content_view_core_;

Powered by Google App Engine
This is Rietveld 408576698