content/browser/android/content_view_core_impl.h - Issue 143803004: android: Migrate old content readback to use async readback (and delegated renderer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 143803004: android: Migrate old content readback to use async readback (and delegated renderer) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/content_startup_flags.cc ('k') | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/renderer_host/compositor_impl_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/content_view_core_impl.h

diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h

index f61e01b3a482ea52cb7bc256e2290a8be07a4784..b1032f843bd65701b9d9adc769582adb66e5694a 100644

--- a/content/browser/android/content_view_core_impl.h

+++ b/content/browser/android/content_view_core_impl.h

@@ -55,9 +55,10 @@ class ContentViewCoreImpl : public ContentViewCore,

virtual void LoadUrl(NavigationController::LoadURLParams& params) OVERRIDE;

virtual jint GetCurrentRenderProcessId(JNIEnv* env, jobject obj) OVERRIDE;

virtual void ShowPastePopup(int x, int y) OVERRIDE;

- virtual unsigned int GetScaledContentTexture(

+ virtual void GetScaledContentBitmap(

float scale,

- gfx::Size* out_size) OVERRIDE;

+ gfx::Size* out_size,

+ const base::Callback<void(bool, const SkBitmap&)>& callback) OVERRIDE;

aelias_OOO_until_Jul13 2014/01/31 05:50:10 It's hard to understand from this API what this ca

powei 2014/02/01 01:30:49 Done.

virtual float GetDpiScale() const OVERRIDE;

virtual void RequestContentClipping(const gfx::Rect& clipping,

const gfx::Size& content_size) OVERRIDE;