Issue 1438003004: bring up SDL on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1438003004: bring up SDL on windows (Closed)

Created:
5 years, 1 month ago by joshualitt

Modified:
5 years, 1 month ago

Reviewers:
bsalomon, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

bring up SDL on windows BUG=skia: patch from issue 1432353002 at patchset 1 (http://crrev.com/1432353002#ps1) Committed: https://skia.googlesource.com/skia/+/dad57c8c48066a2e4b270b9f6992257f7090664c

Patch Set 1 #

Patch Set 2 : disable sdl #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+124 lines, -105 lines)			Patch
M	gyp/views.gyp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/views/sdl/SkOSWindow_SDL.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libsdl/sdl.gypi	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	third_party/libsdl/win/README	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	third_party/libsdl/win/sdl_win.gypi	View	1 chunk	+110 lines, -104 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1438003004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1438003004/20001

5 years, 1 month ago (2015-11-11 21:04:00 UTC) #5

commit-bot: I haz the power

5 years, 1 month ago (2015-11-11 21:17:09 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dad57c8c48066a2e4b270b9f6992257f7090664c

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages