Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1438003002: pkg/js: fix readme for pkg/js and prepare another release (Closed)

Created:
5 years, 1 month ago by kevmoo
Modified:
5 years, 1 month ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix readme for pkg/js and prepare another release Update SDK changelog to mention improved JS interop R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/e7e012e3861b6da8bb0d519c3569a54fffcebe59

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M CHANGELOG.md View 2 chunks +5 lines, -2 lines 0 comments Download
M pkg/js/README.md View 1 3 chunks +17 lines, -11 lines 0 comments Download
M pkg/js/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
kevmoo
5 years, 1 month ago (2015-11-11 19:44:03 UTC) #2
Jacob
https://codereview.chromium.org/1438003002/diff/1/pkg/js/README.md File pkg/js/README.md (right): https://codereview.chromium.org/1438003002/diff/1/pkg/js/README.md#newcode81 pkg/js/README.md:81: @Js() while you are fixing this, change @Js to ...
5 years, 1 month ago (2015-11-11 20:14:21 UTC) #4
Jacob
On 2015/11/11 20:14:21, Jacob wrote: > https://codereview.chromium.org/1438003002/diff/1/pkg/js/README.md > File pkg/js/README.md (right): > > https://codereview.chromium.org/1438003002/diff/1/pkg/js/README.md#newcode81 > ...
5 years, 1 month ago (2015-11-11 20:17:27 UTC) #5
kevmoo
5 years, 1 month ago (2015-11-11 20:19:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e7e012e3861b6da8bb0d519c3569a54fffcebe59 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698