Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1437973002: Oilpan: turn Frame::m_client into the Member it is. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: turn Frame::m_client into the Member it is. R=haraken BUG=553613 Committed: https://crrev.com/10f2692f50c5de5a6bc5f35ecff62f68c5c492df Cr-Commit-Position: refs/heads/master@{#359210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/Frame.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-11 19:37:03 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-11 19:37:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437973002/1
5 years, 1 month ago (2015-11-11 19:39:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/133565)
5 years, 1 month ago (2015-11-11 22:50:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1437973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1437973002/1
5 years, 1 month ago (2015-11-12 01:33:43 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-12 02:41:03 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 20:02:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10f2692f50c5de5a6bc5f35ecff62f68c5c492df
Cr-Commit-Position: refs/heads/master@{#359210}

Powered by Google App Engine
This is Rietveld 408576698