Issue 1437963003: Revert "Fix extraction of colour components in CPDF_DIBSource::DownSampleScanline32Bit"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1437963003: Revert "Fix extraction of colour components in CPDF_DIBSource::DownSampleScanline32Bit" (Closed)

Created:
5 years, 1 month ago by Oliver Chang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Fix extraction of colour components in CPDF_DIBSource::DownSampleScanline32Bit" This reverts commit 9b99615806e358fdb396d1cb162ee2e69c2a20ec. Broke Windows build. TBR=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e451c6da7c54e39910083e528588d1eba3f33b00

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -188 lines)			Patch
M	BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp	View		6 chunks	+29 lines, -38 lines	0 comments	Download
D	core/src/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	pdfium.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	testing/resources/bug_554151.in	View		1 chunk	+0 lines, -59 lines	0 comments	Download
D	testing/resources/bug_554151.pdf	View	1	1 chunk	+0 lines, -70 lines	0 comments	Download

Total messages: 1 (0 generated)

Oliver Chang

5 years, 1 month ago (2015-11-11 23:54:52 UTC) #1

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e451c6da7c54e39910083e528588d1eba3f33b00 (tree was closed).