third_party/WebKit/Source/wtf/Optional.h - Issue 1437943002: Replace WTF::forward with std::forward.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/Optional.h

Issue 1437943002: Replace WTF::forward with std::forward. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed one use of WTF::forward Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/Optional.h

diff --git a/third_party/WebKit/Source/wtf/Optional.h b/third_party/WebKit/Source/wtf/Optional.h

index 264b45ed616936fddd1284997a7c3ff21520e711..e61f28eacd00973fb5493843ed2b049708b76013 100644

--- a/third_party/WebKit/Source/wtf/Optional.h

+++ b/third_party/WebKit/Source/wtf/Optional.h

@@ -9,7 +9,7 @@

#include "wtf/Assertions.h"

#include "wtf/Noncopyable.h"

#include "wtf/StdLibExtras.h"

-#include "wtf/Utility.h"

+#include <utility>

namespace WTF {

@@ -52,7 +52,7 @@ public:

{

RELEASE_ASSERT(!m_ptr);

m_ptr = reinterpret_cast_ptr<T*>(&m_storage.buffer);

- new (m_ptr) T(forward<Args>(args)...);

+ new (m_ptr) T(std::forward<Args>(args)...);

}

private: