Add _embedder.yaml support to analyzer and analysis_server

pkg/analysis_server/lib/src/context_manager.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library context.directory.manager;
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:convert';
 import 'dart:core' hide Resource;
 
 import 'package:analysis_server/plugin/analysis/resolver_provider.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/instrumentation/instrumentation.dart';
 import 'package:analyzer/plugin/options.dart';
 import 'package:analyzer/source/analysis_options_provider.dart';
+import 'package:analyzer/source/embedder.dart';
 import 'package:analyzer/source/package_map_provider.dart';
 import 'package:analyzer/source/package_map_resolver.dart';
 import 'package:analyzer/source/path_filter.dart';
 import 'package:analyzer/source/pub_package_map_provider.dart';
 import 'package:analyzer/source/sdk_ext.dart';
 import 'package:analyzer/src/context/context.dart' as context;
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/java_engine.dart';
 import 'package:analyzer/src/generated/java_io.dart';
 import 'package:analyzer/src/generated/source.dart';
@@ skipping 1374 matching lines @@
 
   PackageMapDisposition(this.packageMap, {this.packageRoot});
 
   @override
   Packages get packages => null;
 
   @override
   Iterable<UriResolver> createPackageUriResolvers(
           ResourceProvider resourceProvider) =>
       <UriResolver>[
+        new EmbedderUriResolver(packageMap),

[pquitslund, 2015/11/11 19:19:09]

A consequence of doing the _embedder.yaml discovery in the resolver is that
we'll need to do it again for options.  It might be better if we could do that
just once?  (Aside: there's technically a race condition too in case that file
gets changed between reads but that's a bit pathological.)

What about hoisting that logic up and into context_manager and passing in the
discovered yaml file(s)?

[Brian Wilkerson, 2015/11/11 22:09:14]

What do you mean by "options"?

[pquitslund, 2015/11/11 23:17:16]

Analysis options can also be set by embedders in this file.  They will set the
defaults (available for overriding in a local `.analysis_options` file).

[Brian Wilkerson, 2015/11/11 23:59:36]

Right! I'd forgotten. Thanks.

         new SdkExtUriResolver(packageMap),
         new PackageMapUriResolver(resourceProvider, packageMap)
       ];
 }
 
 /**
  * Concrete [FolderDisposition] object indicating that the context for a given
  * folder should resolve packages using a ".packages" file.
  */
 class PackagesFileDisposition extends FolderDisposition {
@@ skipping 10 matching lines @@
       ResourceProvider resourceProvider) {
     if (packages != null) {
       // Construct package map for the SdkExtUriResolver.
       Map<String, List<Folder>> packageMap = <String, List<Folder>>{};
       packages.asMap().forEach((String name, Uri uri) {
         if (uri.scheme == 'file' || uri.scheme == '' /* unspecified */) {
           var path = resourceProvider.pathContext.fromUri(uri);
           packageMap[name] = <Folder>[resourceProvider.getFolder(path)];
         }
       });
-      return <UriResolver>[new SdkExtUriResolver(packageMap)];
+      return <UriResolver>[new EmbedderUriResolver(packageMap),
+                           new SdkExtUriResolver(packageMap)];
     } else {
       return const <UriResolver>[];
     }
   }
 }